Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some link outs convert the delimiter :|: to :%7C: for being unsafe #10258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pxt-core",
"version": "11.2.20",
"version": "11.2.21",
"description": "Microsoft MakeCode provides Blocks / JavaScript / Python tools and editors",
"keywords": [
"TypeScript",
Expand Down
5 changes: 5 additions & 0 deletions webapp/public/multi.html
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,12 @@
var hashLeft = ""
var hashRight = ""
var route = (window.location.hash || "#");
// Split using :|: as well as :%7C:
var parts = route.replace(/^#/, '').split(':|:', 2);
if (parts.length == 1) {
//As some link out conver :|: to :%7C:
parts = route.replace(/^#/, '').split(':%7C:', 2);
}
updateSrc(left, parts[0]);
updateSrc(right, parts[1]);
window.history.replaceState('', '', '#')
Expand Down
Loading