Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partner telemetry flag #10005

Merged
merged 1 commit into from
May 6, 2024
Merged

Add partner telemetry flag #10005

merged 1 commit into from
May 6, 2024

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented May 6, 2024

Adds a query parameter that lets you add a custom "partner" property to all of the telemetry items that are logged to app insights. The purpose of this feature is to let us differentiate between traffic generated by partners that link to or embed us; think of it as a manual referrer property that can be embedded in a URL. This parameter is added to all tick events.

url should look like this:

arcade.makecode.com/?partner=partnerName

Right now I am not removing the query parameter from the URL. I can do that, though, if we want.

Here is a test upload:

https://arcade.makecode.com/app/088c007a20a09fcee83221eeda1df6c9dd2a1f5b-590b47925d

@riknoll riknoll requested review from abchatra and a team May 6, 2024 22:01
Copy link
Contributor

@thsparks thsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@abchatra
Copy link
Collaborator

abchatra commented May 6, 2024

Lets hotfix to microbit.

@riknoll riknoll merged commit 1b0949c into master May 6, 2024
7 checks passed
@riknoll riknoll deleted the dev/riknoll/partner-telemetry branch May 6, 2024 23:51
riknoll added a commit that referenced this pull request May 6, 2024
riknoll added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants