Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags to visible criteria #5656

Merged
merged 1 commit into from
May 10, 2024
Merged

Add tags to visible criteria #5656

merged 1 commit into from
May 10, 2024

Conversation

thsparks
Copy link
Contributor

@thsparks thsparks commented May 7, 2024

Tag support added in microsoft/pxt#10007, need to add for microbit criteria as well.

@thsparks thsparks requested a review from a team May 7, 2024 21:56
srietkerk
srietkerk approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@srietkerk srietkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where this would live, but it might be nice to have documentation that outlines standards that we should use when applying a tag to a criteria entry. Looks good to me, though!

@thsparks thsparks merged commit da41ee3 into master May 10, 2024
7 checks passed
@thsparks thsparks deleted the thsparks/teachertool/tags branch May 10, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srietkerk srietkerk srietkerk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thsparks @srietkerk