apply comments

microsoft · Mar 15, 2024 · 1e11478 · 1e11478
1 parent 664f7fa
commit 1e11478
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/_locales/de/jacdac-strings.json b/_locales/de/jacdac-strings.json
@@ -85,7 +85,7 @@
   "jacdac.ProtoTestEvent.EU32|block": "e u32",
   "jacdac.ProtoTestEvent.EU8String": "Ein Ereignis, das ausgelöst wird, wenn rw_u8_string geändert wird.",
   "jacdac.ProtoTestEvent.EU8String|block": "e u8 string",
-  "jacdac.ProtoTestReg.RoBool": "Nur-Lesen bool (uint8_t).",
+  "jacdac.ProtoTestReg.RoBool": "Nur-Lesen Bool (uint8_t).",
   "jacdac.ProtoTestReg.RoBytes": "Nur-Lesen Bytes.",
   "jacdac.ProtoTestReg.RoI32": "Nur-Lesen int32_t.",
   "jacdac.ProtoTestReg.RoI8U8U16I32": "Ein nur-lesen i8, u8, u16, i32 Register.",
@@ -100,7 +100,7 @@
   "jacdac.ProtoTestReg.RwU32": "Lese-Schreib-uint32_t.",
   "jacdac.ProtoTestReg.RwU8String": "Ein lese-schreib u8, String Register.",
   "jacdac.RoleManagerCmd.ClearAllRoles": "Keine Argumente.",
-  "jacdac.RoleManagerCmd.ListRoles": "Argument: Rollen pipe (Bytes).",
+  "jacdac.RoleManagerCmd.ListRoles": "Argument: Rollen Pipe (Bytes).",
   "jacdac.RoleManagerCmd.SetRole": "Rolle setzen.",
   "jacdac.RoleManagerEvent.Change": "Benachrichtigt, dass sich die Rollenbindungen geändert haben.",
   "jacdac.RoleManagerEvent.Change|block": "Änderung",
@@ -112,8 +112,8 @@
   "jacdac.SettingsCmd.Clear": "Keine Argumente.",
   "jacdac.SettingsCmd.Delete": "Argument: Schlüssel String (Bytes).",
   "jacdac.SettingsCmd.Get": "Argument: Schlüssel String (Bytes).",
-  "jacdac.SettingsCmd.List": "Argument: Ergebnisse pipe (Bytes).",
-  "jacdac.SettingsCmd.ListKeys": "Argument: Ergebnisse pipe (Bytes).",
+  "jacdac.SettingsCmd.List": "Argument: Ergebnisse Pipe (Bytes).",
+  "jacdac.SettingsCmd.ListKeys": "Argument: Ergebnisse Pipe (Bytes).",
   "jacdac.SettingsCmd.Set": "Bericht Get.",
   "jacdac.SettingsEvent.Change": "Benachrichtigt, dass einige Einstellungen geändert wurden.",
   "jacdac.SettingsEvent.Change|block": "Änderung",

diff --git a/character-screen/_locales/de/jacdac-character-screen-strings.json b/character-screen/_locales/de/jacdac-character-screen-strings.json
@@ -8,8 +8,8 @@
   "jacdac.CharacterScreenTextDirection.LeftToRight|block": "von links nach rechts",
   "jacdac.CharacterScreenTextDirection.RightToLeft|block": "von rechts nach links",
   "jacdac.CharacterScreenVariant.Braille|block": "braille",
-  "jacdac.CharacterScreenVariant.LCD|block": "lcd",
-  "jacdac.CharacterScreenVariant.OLED|block": "oled",
+  "jacdac.CharacterScreenVariant.LCD|block": "LCD",
+  "jacdac.CharacterScreenVariant.OLED|block": "OLED",
   "modules.CharacterScreenClient.brightness|block": "%characterscreen Helligkeit",
   "modules.CharacterScreenClient.clear|block": "lösche %characterscreen",
   "modules.CharacterScreenClient.setBrightness|block": "setze %characterscreen Helligkeit auf %value",

diff --git a/genaisrc/loc-strings.genai.js b/genaisrc/loc-strings.genai.js
@@ -122,9 +122,16 @@ and should be translated following these rules:
 - Make sure to translate '\\%' to '\\%' and '\\$' to '\\$' if they are not variables.
 - Event string starts with 'on', like 'on pressed'. Interpret 'on' as 'when' when, like 'when pressed', when translating.
 - The translations of "...|block" string should be short.
+- Capitalize acronyms (LCD, OLED), Bool.
 
 `
 
+// language specific instructions
+if (langCode === "de") {
+    $`- Capitalize Pipe in translations.`
+}
+
+
 // add to prompt context
 def(
     "ORIGINAL",