-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hero-banner.md #6453
Update hero-banner.md #6453
Conversation
Shortening the description text
docs/hero-banner.md
Outdated
@@ -14,7 +14,7 @@ Here are some cool activities to get you started! | |||
--- | |||
* name: Build a Bubble Popping Game | |||
* buttonLabel: Code Now | |||
* description: Create your own bubble popping game with the crew from Disney & Pixar's Inside Out 2! | |||
* description: Code with images from Disney & Pixar's Inside Out 2! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this, but I'll note that it does sound a little like we're using the images to write actual code (as opposed to blocks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.. I like the little crew sentiment in there, I think that's cute. Could it be changed to something like Code with the crew (maybe emotions here?) from Disney and Pixar's Inside Out 2
? It's a bit of a nod to the first pop-up, too, since the pop-up says "are you ready to try something new with Joy and the rest of the emotions..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I tried to figure out how to leave it in, but I think it's still too long. Since the banner already has the Disney/Pixar stuff in it, we could probably just say "Code a game featuring some of our favorite characters." Because, technically, I need to get everything approved by Disney/Pixar if we use their brand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "Code a game featuring characters from the new movie!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that a lot!!
Modifying to text that doesn't need Disney/Pixar approval.
* Update hero-banner.md Shortening the description text * Update hero-banner.md Modifying to text that doesn't need Disney/Pixar approval.
* Update hero-banner.md (#6453) * Update hero-banner.md Shortening the description text * Update hero-banner.md Modifying to text that doesn't need Disney/Pixar approval. * Updating Educator Page (#6454) --------- Co-authored-by: Kiki Prottsman <[email protected]>
Shortening the description text so it doesn't try to scroll anymore.