-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility compliance: editor colors update #6425
Conversation
"colour": "rgba(107, 79, 118, 0.10)", | ||
"snap": true | ||
"spacing": 30, | ||
"length": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know exactly what's happening here, but is 1 a typo? That seems too small to be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, not a typo! 1 makes it so that the point that is being used for the grid is a circle! https://developers.google.com/blockly/guides/configure/web/grid#length
I guess I didn't read the docs close enough, though, because it looks like 1 is the default, so I might be able to just get rid of that field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, but not a huge concern
Good catch, I will add that, thanks! |
Arcade's orange does not allow for accessible contrast. We could try to darken it, but that would not create a desirable color, so we've decided to update the arcade theme.
Fixes microsoft/pxt-microbit#5469
Fixes #3973
Fixes microsoft/pxt-microbit#5465
Please play around with this! I think it will be good to use a testing session for everyone to get a feel with it, but there are a lot of spots that have different styling, so there might be something that I missed. Note that the "New? Start Here" labels are orange right now because the color is changed in docs. https://arcade.makecode.com/app/3e33481bd3886ff462d55b14af25a3360e2a0402-0e60e79eaf#