Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility compliance: editor colors update #6425

Merged
merged 2 commits into from
May 24, 2024

Conversation

srietkerk
Copy link
Contributor

Arcade's orange does not allow for accessible contrast. We could try to darken it, but that would not create a desirable color, so we've decided to update the arcade theme.

Fixes microsoft/pxt-microbit#5469
Fixes #3973
Fixes microsoft/pxt-microbit#5465

Please play around with this! I think it will be good to use a testing session for everyone to get a feel with it, but there are a lot of spots that have different styling, so there might be something that I missed. Note that the "New? Start Here" labels are orange right now because the color is changed in docs. https://arcade.makecode.com/app/3e33481bd3886ff462d55b14af25a3360e2a0402-0e60e79eaf#

"colour": "rgba(107, 79, 118, 0.10)",
"snap": true
"spacing": 30,
"length": 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know exactly what's happening here, but is 1 a typo? That seems too small to be useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, not a typo! 1 makes it so that the point that is being used for the grid is a circle! https://developers.google.com/blockly/guides/configure/web/grid#length

I guess I didn't read the docs close enough, though, because it looks like 1 is the default, so I might be able to just get rid of that field

@thsparks
Copy link
Contributor

I noticed these are remaining purple in high contract mode now. Do we need to add a new case in the hc css?
image

In live, they go black and white:
image

Copy link
Contributor

@thsparks thsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but not a huge concern

@srietkerk
Copy link
Contributor Author

I noticed these are remaining purple in high contract mode now. Do we need to add a new case in the hc css?

Good catch, I will add that, thanks!

@srietkerk srietkerk merged commit c37d19a into master May 24, 2024
3 checks passed
@srietkerk srietkerk deleted the srietkerk/editor-colors-update branch May 24, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment