Teacher tool: added styling for teachertool=1 url flag #6327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eanders-ms
approved these changes
Jan 17, 2024
thsparks
approved these changes
Jan 17, 2024
abchatra
reviewed
Jan 20, 2024
| "teachertool=1": { | ||
| "appTheme": { | ||
| "hideMenuBar": true, | ||
| "workspaceSearch": true |
There was a problem hiding this comment.
Why enable workspace search here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might want to look into a different and more "sticky" pattern for this because if we do the styling this way, we'd have to define this flag in each target. I wasn't sure if there was a way to define url query parameters like this universally without the backend.