Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a card to "Download to Drive" #6264

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Draft

Adding a card to "Download to Drive" #6264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions targetconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,12 @@
]
},
"hardwareOptions": [
{
"name": "Download to Drive",
"description": "Download a copy of your game file to your computer",
"imageUrl": "/static/hardware/laptop.png",
"variant": "hw---stm32f401"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this compiling to stm32f401?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we don't have a variant that creates a png and this is the variant attached to the button people are most-likely to select if they use download today.

@riknoll suggested we would eventually want to do the work to make a .png variant.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be thought through. We don't select variant when saving through save icon. Let's wait on this change for next release.

},
{
"name": "Meowbit",
"description": "A retro game console for STEM education from Kittenbot team",
Expand Down
Loading