Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try and fix the 'Music' main reference page for the new 'play' api #6080

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

ganicke
Copy link
Collaborator

@ganicke ganicke commented Sep 21, 2023

Refactored the use of the music.play() card and listed the 3 forms of its use.

Note: The JsDoc for the music.play() is missing on the header for the function in pxt-common-packages. This leaves the card description empty. I will fix that in a different PR for that repo.

image

Closes #6078

Depends on microsoft/pxt-common-packages#1457

@ganicke ganicke requested a review from Jaqster September 21, 2023 01:57
@ganicke
Copy link
Collaborator Author

ganicke commented Sep 21, 2023

Hmm, need to add the sound effect blocks too.

Copy link
Member

@Jaqster Jaqster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Galen!

@ganicke ganicke merged commit c4dbc14 into master Sep 28, 2023
3 checks passed
@ganicke ganicke deleted the fix-music-ref-page branch September 28, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing some links in Music reference
2 participants