release v1.12.41 #6077
Merged
release v1.12.41 #6077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6075
unfortunately #6076 seems to have fixed it, will have to chat on proper investigation here. I think there's some weirdness going on here, a few minutes of poking around I could get why the folder it's looking for is different (
/codicons/codicon/codicon.ttfbut actual file is at/codiconLabel/codicon/codicon.tsbut maybe there's just some minor connection I'm missing in the gulpfile)Issue is that it's fetching https://pxt.azureedge.net/blob/d54cbaf4e99b7b3c8ea6a714f9f0bc40554451ac/vs/base/browser/ui/codicons/codicon/codicon.ttf but that's resolving to the monaco embed css file, which is... clearly wrong. Running pxt build again and redeploying seems to have resolved it 🥲
