Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge names are too long #4320

Closed
riknoll opened this issue Nov 11, 2021 · 7 comments · May be fixed by #4378
Closed

Badge names are too long #4320

riknoll opened this issue Nov 11, 2021 · 7 comments · May be fixed by #4378
Assignees
@kiki-lee
Labels
badges bug Something isn't working
Milestone
Feb 2022 hotfix

Comments

@riknoll
Copy link
Member

riknoll commented Nov 11, 2021

The display names for badges are too long. It looks fine with one or two, but when you have several you get this:

Screen Shot 2021-11-10 at 5 01 20 PM

I think we either need to shorten the display name for our maps or add a secondary field to specify the name of the badge. In general we should probably find a more consistent style for how we name our skillmaps and badges.
@riknoll riknoll added bug Something isn't working badges labels Nov 11, 2021
@abchatra
Copy link
Collaborator

For now I put some hack in for disabled badges. We need to fix this and take hotfix.

@abchatra abchatra added this to the Hour of Code milestone Nov 11, 2021
@riknoll riknoll mentioned this issue Nov 11, 2021
Merged
@kiki-lee
Copy link
Contributor

Yes! We can have a field in the skillmap for the "nickname". That will be good for data collection, too. In general, the nicknames are the name of the md file (beginner will be an exception).

  • Shark
  • Forest
  • Space
  • etc

@riknoll riknoll mentioned this issue Nov 18, 2021
Draft
@abchatra
Copy link
Collaborator

@riknoll @kiki-lee is this fixed?

@abchatra
Copy link
Collaborator

abchatra commented Feb 3, 2022

@riknoll @kiki-lee ping!

@riknoll
Copy link
Member Author

riknoll commented Feb 3, 2022

Finished on the engineering side! I don't know the status of the markdown

@riknoll riknoll removed their assignment Feb 3, 2022
@abchatra
Copy link
Collaborator

abchatra commented Feb 4, 2022

@kiki-lee ?

@abchatra abchatra modified the milestones: Feb 2022, Feb 2022 hotfix Feb 9, 2022
@kiki-lee
Copy link
Contributor

All markdown is updated. Now we just have to remember to put it in all skillmaps going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kiki-lee kiki-lee

Labels
badges bug Something isn't working
Projects
None yet
Milestone
Feb 2022 hotfix
Development

Successfully merging a pull request may close this issue.

Add new badge/certificate authoring microsoft/pxt-arcade
3 participants
@kiki-lee @abchatra @riknoll