Check bias shape in operator Conv #22760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianleiwu
reviewed
Nov 7, 2024
| Status ValidateInputShape(const Tensor* input, const Tensor* weight, const Tensor* bias = nullptr) const { | ||
| if (bias == nullptr) | ||
| return ValidateInputShape(input->Shape(), weight->Shape()); | ||
| return ValidateInputShape(input->Shape(), weight->Shape(), bias->Shape()); |
There was a problem hiding this comment.
Need pass input_channels_last and weight_challels_last to support NHWC (channel last) Conv? Or maybe add a comment here that CPU only support NCHW right now.
tianleiwu
reviewed
Nov 7, 2024
| bool weight_channels_last = false) const { | ||
| Status status = ValidateInputShape(input_shape, weight_shape, input_channels_last, weight_channels_last); | ||
| if (status.IsOK()) { | ||
| if (bias_shape.Size() > 1) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bias shape is not checked as the other shapes when operator Conv is called. That could lead to unwanted memory access.
Motivation and Context
Catch potential memory issue.