Add ReduceMean shape infer to SymbolicShapeInference #22722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianleiwu
reviewed
Nov 5, 2024
Comment on lines
168
to
+169
| "ReduceSum": self._infer_ReduceSum, | ||
| "ReduceMean": self._infer_ReduceMean, |
There was a problem hiding this comment.
ReduceSum and ReduceMean could use same shape infer function.
Also applies to ReduceMin, ReduceMax, ReduceProd etc.
tianleiwu
reviewed
Nov 5, 2024
| vi = self.known_vi_[node.output[0]] | ||
|
|
||
| if axes is None: | ||
| assert keep_dims == 1, "ReduceMean Op: Cannot infer shape when axes is unknown and keepdims is not 1." |
There was a problem hiding this comment.
opset 18 add an attribute noop_with_empty_axes, shall we handle it here.
https://onnx.ai/onnx/operators/onnx__ReduceMean.html#reducemean-18
tianleiwu
reviewed
Nov 5, 2024
| keep_dims = get_attribute(node, "keepdims", 1) | ||
| opset = get_opset(self.out_mp_) | ||
|
|
||
| if opset >= 13 and len(node.input) > 1: |
There was a problem hiding this comment.
ReduceMean-13 still uses attribute for axes. Maybe just check whether there is two inputs, and not check opset version so that it is more general for other Reduce* op. For example, starting with ReduceSum-13, ReduceMean-18, ReduceMax-18, axes is in input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add symbolic shape inference support of ReduceMean op
ReduceMean def: https://onnx.ai/onnx/operators/onnx__ReduceMean.html
Motivation and Context
#22662
This op is not supported by current script