fix webgpu precision errors #22718
Open
fix webgpu precision errors #22718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guschmue
reviewed
Nov 6, 2024
| @@ -116,7 +116,7 @@ Status SkipLayerNorm<simplified>::ComputeInternal(onnxruntime::webgpu::ComputeCo | |||
| auto* output = context.Output(0, x_shape); | |||
| auto* input_skip_bias_sum = context.Output(3, x_shape); | |||
|
|
|||
| size_t data_size = x_shape.Size(); | |||
There was a problem hiding this comment.
trying to understand the issue - the fix is for android/32bit?
fs-eire
reviewed
Nov 7, 2024
| @@ -85,7 +85,7 @@ class SimpleCacheManager : public IBufferCacheManager { | |||
|
|
|||
| void OnRefresh() override { | |||
| for (auto& buffer : pending_buffers_) { | |||
| buffers_[wgpuBufferGetSize(buffer)].push_back(buffer); | |||
| buffers_[static_cast<unsigned int>(wgpuBufferGetSize(buffer))].push_back(buffer); | |||
There was a problem hiding this comment.
wgpuBufferGetSize() returns uint64_t. casting to size_t should work
There was a problem hiding this comment.
same to the other occurrence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds explicit casting to silence CI errors related to webgpu kernels
Motivation and Context
ORT Inf/Core DRI