Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to single connection #190

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Alan-Jowett
Copy link
Member

This pull request includes changes to the GitHub workflows cts_traffic.yml and ebpf.yml. The changes primarily focus on modifying the test parameters and simplifying the workflow by removing unnecessary steps. The test parameters have been updated to include duration and concurrent_connections, replacing the tcp_ip_tracing parameter. The workflows have also been simplified by removing steps related to TCP/IP tracing and ETL file uploads.

Changes to test parameters:

  • .github/workflows/cts_traffic.yml and .github/workflows/ebpf.yml: Replaced the tcp_ip_tracing parameter with duration and concurrent_connections parameters. The duration parameter specifies the duration of the test in milliseconds or seconds, and the concurrent_connections parameter specifies the number of concurrent connections. [1] [2]

Simplification of workflows:

  • .github/workflows/cts_traffic.yml and .github/workflows/ebpf.yml: Removed steps related to TCP/IP tracing and ETL file uploads. These steps were removed as they are no longer necessary due to the changes in test parameters. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Adjustments to test execution:

  • .github/workflows/cts_traffic.yml and .github/workflows/ebpf.yml: Adjusted the test execution to use the new duration and concurrent_connections parameters. The test execution now takes these parameters into account when running the tests. [1] [2] [3]

Alan Jowett added 2 commits May 24, 2024 15:24
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
@ProjectsByJackHe ProjectsByJackHe self-requested a review May 28, 2024 22:00
Copy link
Collaborator

@ProjectsByJackHe ProjectsByJackHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR is being used instead of 'main' to run workflows, feel free to merge this and base future work off 'main'. I don't have as much context in ebpf perf testing, but from the excellent PR description, these changes makes sense / looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants