Skip to content

Commit

Permalink
formatting changes from comments
Browse files Browse the repository at this point in the history
  • Loading branch information
karkarl committed Dec 9, 2024
1 parent 649c560 commit e466acb
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
6 changes: 3 additions & 3 deletions specs/TitleBar/titleBar-dev-spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ to encapsulate the most common design scenarios and streamline this process.

# Design considerations

## AppWindow TitleBar (IXP) vs. WinUI TitleBar
## AppWindow TitleBar versus WinUI TitleBar

![Basic TitleBar](images/titlebar-basic.png)

### AppWindow.TitleBar (IXP)
### AppWindow.TitleBar
The AppWindow TitleBar is the default title bar, and downlevels to Win32.

AppWindow drawn title bar covers the basic functionalities:
Expand Down Expand Up @@ -148,7 +148,7 @@ _The Default LayoutUpdated event fires for every little (non-relevant) events._

# Functional spec link

[Functional Spec](images/titleBar-functional-spec.md)
[Functional Spec](titleBar-functional-spec.md)

# Architectural overview

Expand Down
18 changes: 8 additions & 10 deletions specs/TitleBar/titlebar-functional-spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,16 @@ A title bar is a core component of a Windows app, and the shell version of the t

Use the WinUI TitleBar when you want further customizations such as subtitles, Mica theming, and integrations with WinUI Controls.

_Note: WinUI TitleBar does not handle Caption Buttons - it simply allocates space on the right side.
_Note: WinUI TitleBar does not handle Caption Buttons - it simply allocates space where the caption buttons appear, depending on RTL or LTR settings.
Caption Buttons and its customizations are handled by the AppWindow TitleBar._

# Sample scenarios

## **Scenario: Default TitleBar**
## Scenario: Default TitleBar
![alt text](images/default-titlebar.png)

XAML
```xaml
**XAML**
```xml
<Window
x:Class="App1.MainWindow"
xmlns:local="using:App1"
Expand Down Expand Up @@ -94,12 +94,12 @@ _Note: TitleBar currently needs to be set explicitly in the grid.row and referen
_by Window in codebehind as shown above._
_Improvements to Window are being considered to avoid this extra grid layout and codebehind._

## **Scenario: TitleBar with WinUI Controls Integration**
## Scenario: TitleBar with WinUI Controls Integration
TitleBar with common WinUI Controls: `AutoSuggestBox`, `PersonPicture`, `AppBarButton`.

![alt text](images/controls-titlebar.png)

XAML
**XAML**
```xml
<TitleBar
x:Name="ControlsTitleBar"
Expand All @@ -123,7 +123,7 @@ XAML
</TitleBar>
```

## **Scenario: TitleBar with NavigationView L-Pattern Integration**
## Scenario: TitleBar with NavigationView L-Pattern Integration

<!-- TODO: Update image to have NavPane Button inline with TitleBar -->
Titlebar and NavigationView in an L-Pattern.
Expand All @@ -133,7 +133,7 @@ TitleBar and NavigationView is in Minimal DisplayMode.
Note that TitleBar IconSource is collapsed in minimal mode.
![alt text](images/titlebar-navview-minimal.png)

XAML
**XAML**
```xml
<Grid>
<Grid.RowDefinitions>
Expand Down Expand Up @@ -172,7 +172,6 @@ XAML
</NavigationView.Menuitems>
</NavigationView>
</Grid>

```

_Note: Should the NavView resources be the default to avoid needing the extra code?_
Expand Down Expand Up @@ -465,7 +464,6 @@ unsealed runtimeclass TitleBarAutomationPeer : Microsoft.UI.Xaml.Automation.Peer
{
TitleBarAutomationPeer(MEU_XC_NAMESPACE.TitleBar owner);
}

```

# Figma link
Expand Down

0 comments on commit e466acb

Please sign in to comment.