Fix crash in RefreshVisualizer when not wrapping a ScrollViewer (#1328)

microsoft · Sep 17, 2019 · c007095 · c007095
1 parent 67537d9
commit c007095
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/dev/PullToRefresh/RefreshVisualizer/RefreshVisualizer.cpp b/dev/PullToRefresh/RefreshVisualizer/RefreshVisualizer.cpp
@@ -298,7 +298,13 @@ void RefreshVisualizer::UpdateContent()
             contentVisual.Opacity(1.0f);
             if (m_root)
             {
-                float translationRatio = (1.0f - (float)(m_refreshInfoProvider.get().ExecutionRatio())) * PARALLAX_POSITION_RATIO;
+                float translationRatio = [this]() {
+                    if (auto&& refreshInfoProvider = m_refreshInfoProvider.get())
+                    {
+                        return (1.0f - (float)(refreshInfoProvider.ExecutionRatio())) * PARALLAX_POSITION_RATIO;
+                    }
+                    return 1.0f;
+                }();
                 translationRatio = IsPullDirectionFar() ? -1.0f * translationRatio : translationRatio;
                 //On RS2 and above we achieve the parallax animation using the Translation property, so we set the appropriate field here.
                 if (SharedHelpers::IsRS2OrHigher())