Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervised Metric Pretraining #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

chingisooinar
Copy link

Hello,
I am writing from my first account. I would like to add an option for supervised metric pretraining. It is used with LinearAverage from LinearAverage.py since the output is expected to be passed to this class. It performs eq. (4) as mentioned in https://arxiv.org/pdf/1812.08781.pdf. Also, I found using the temperature parameter handy, as mentioned in https://arxiv.org/pdf/1805.01978.pdf. Thanks for your consideration.

@ghost
Copy link

ghost commented Jan 27, 2021

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@bl0 bl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work. But maybe you should address the following two concerns before the PR is merged.

  1. You should reformat the code to make it clean.
  2. Maybe you should make it runnable.

@chingisooinar
Copy link
Author

Thank you, I refactored it and included a sample code for imagenet dataset.

@bl0
Copy link
Collaborator

bl0 commented Jan 28, 2021

Thanks a lot for your quick reply.
Can you post the training and finetuning log of the sample code? I want to check the correctness and performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants