Fix: Kiota extension works without a workspace folder open #4958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ElinorW this pull request is conflicting, any chance you could resolve the conflicts before we review it please? |
… into elinor/open-output
baywet
reviewed
Jul 12, 2024
baywet
requested changes
Jul 15, 2024
baywet
reviewed
Jul 16, 2024
baywet
approved these changes
Jul 17, 2024
| break; | ||
| return; | ||
| } | ||
| if (result && getLogEntriesForLevel(result, LogLevel.critical, LogLevel.error).length === 0) { |
There was a problem hiding this comment.
+1 on this
Do we also want an else clause that displays the reaons for the generation failure by picking the log entry that matches LogLevel.critical?
There was a problem hiding this comment.
Sure, we can display the error in the case of LogLevel.critical
Co-authored-by: Andrew Omondi <[email protected]>
… into elinor/open-output
|
Can't merge this just yet... |
|
This was referenced Jul 26, 2024
ElinorW
added a commit
that referenced
this pull request
Aug 22, 2024
* add tree view * add Api files conatiner and remove previous containers * rename workspace title * combine search and open description functions * Add 'close description' button to api title node * add close description dialog * add generate option step * added plugin dialog steps * added icon toggling * add workspace.json file to workspace * Fix some server configs * Ensure the RPC commands use preview features if config is enabled. * - updates references kiota version for CLI * - cleans up localization files from unused resource Signed-off-by: Vincent Biret <[email protected]> * - removes unimplemented command Signed-off-by: Vincent Biret <[email protected]> * - adds the environment variable passing to the json RPC server Signed-off-by: Vincent Biret <[email protected]> * - refactors to constant Signed-off-by: Vincent Biret <[email protected]> * - removes serializers in preview mode Signed-off-by: Vincent Biret <[email protected]> * - code linting * - initial plugin generation Signed-off-by: Vincent Biret <[email protected]> * Fixed the collection of plugin name * rename title string * Add plugin type step * add generate a manifest type * close description after generation * add "Edit Path' button * add regenerate call * update file name * enable editing paths on api explorer * add regenerate functionality * - bumps kiota versions to avoid updates which confuses @sebastienlevert and @maisarissi * - adds FAQ documentation for vs code reinstalling over * add regeneration button on api explorer * remove automatic workspace.json file add * replace string * update icon * add plugin re-generation * add warning notification * add save notification * fix delete description appearing on wrong nodes * remove open file command * remove output path validation and default to ouptut folder * move constants to separate file * remove path autoselection when description is loaded for the first time * fix workspace.json file not opening * hide add and remove icon on apiTitle node * undo closing descriptions after generation * Adding the automatic sideloading script * Update to using vsx * fix icons display * Merge branch 'main' into elinor/add-kiota-workspace * remove welcome translations * remove welcome string translation * add string translations * remove unused search lock function * add french translations * added czech translations * add portuguese translations * update output diectory string * set workspace file constant * add else clause * remove TODO comments * return vscode error * add types * use nullish coalescing operator instead of Logical OR * add spanish translations * add italian translation * add chinese translations * remove unused functions * update static strings * add missing l10n * update string typo * update static string localization files * update french string * remove else Co-authored-by: Musale Martin <[email protected]> * add plugin output selection * add output directory selection for client generation * add output directory selection for manifest generation * add polish translations * add russian translations * add swahili translations * add success message and toggle icons * add constants * localize string * add default and browse output options * add dropdown for api path selection * remove unused filter property * remove else Co-authored-by: silaskenneth <[email protected]> * update icon * Fixing vscode sideloading script for Windows * enable generation from a deeplink * Updates plugin naming * update vscode engine * bump kiota extension version * Task: Display client/plugin name on API explorer (#4801) * hide information messages * update warning message display * update regenerate function * Add constants * Fix: "Override" message only displays if there's a change on the tree (#4899) * code clean up * update plugin type to accept array * chore: lock update * chore: bumps version to avoid auto-update * Fixes unselected paths * format * fix regeneration * API change to migrate lockfile to workspace file * Adds connections to migrate workspace file * Fix path maching * Update vscode/microsoft-kiota/src/openApiTreeProvider.ts * Fixes plugin generation check * Fix: Add paste path functionality (#4994) * Fix: Kiota extension works without a workspace folder open (#4958) * Fix: Workspace file display (#5029) * Fix: Display "override" message only when changes have been made (#5048) * fix typo issue * fix typecase * fix cwd update * chore: bumps extension engine version * chore: updates lock file * Feat: Add migration dialog (#5144) * chore: adds missing french translations * add missing translations * simpify function * rename function * fix: bumps vscode extension version to allow side-loading * update message display * use workspace instead of lock Co-authored-by: Andrew Omondi <[email protected]> * use workspaceFile instead * format file * add missing translations * update function name * format file --------- Signed-off-by: Vincent Biret <[email protected]> Co-authored-by: Andrew Omondi <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: Eastman <[email protected]> Co-authored-by: Sébastien Levert <[email protected]> Co-authored-by: Musale Martin <[email protected]> Co-authored-by: silaskenneth <[email protected]> Co-authored-by: Sébastien Levert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4852
Fixes #4766