feat: plugins generation no longer emits parameters

CHANGELOG.md

@@ -13,7 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - TypeScript imports are now using ES6 imports with the .js extension.
 - Remove LINQ usage in generated code.
-- Ensures descriptions are not empty in sliced OpenApi file when generating a plugin. 
+- Ensures descriptions are not empty in sliced OpenApi file when generating a plugin.
+- Plugins do not emit parameters anymore. [#4841](https://github.com/microsoft/kiota/issues/4841)
 
 ## [1.15.0] - 2024-06-06
 

src/Kiota.Builder/Plugins/PluginsGenerationService.cs

@@ -72,7 +72,7 @@
                     pluginDocument.Write(writer);
                     break;
                 case PluginType.APIManifest:
                     var apiManifest = new ApiManifestDocument("application"); //TODO add application name
                     // pass empty config hash so that its not included in this manifest.
                     apiManifest.ApiDependencies.AddOrReplace(Configuration.ClientClassName, Configuration.ToApiDependency(string.Empty, TreeNode?.GetRequestInfo().ToDictionary(static x => x.Key, static x => x.Value) ?? [], WorkingDirectory));
                     var publisherName = string.IsNullOrEmpty(OAIDocument.Info?.Contact?.Name)
@@ -179,7 +179,7 @@
             Schema = "https://aka.ms/json-schemas/copilot-extensions/v2.1/plugin.schema.json",
             SchemaVersion = "v2.1",
             NameForHuman = OAIDocument.Info?.Title.CleanupXMLString(),
             // TODO name for model ???
             DescriptionForHuman = descriptionForHuman,
             DescriptionForModel = manifestInfo.DescriptionForModel ?? descriptionForHuman,
             ContactEmail = manifestInfo.ContactEmail,
@@ -249,35 +249,13 @@
                     },
                     RunForFunctions = [operation.OperationId]
                 });
-                var oasParameters = operation.Parameters
-                                        .Union(pathItem.Parameters.Where(static x => x.In is ParameterLocation.Path))
-                                        .Where(static x => x.Schema?.Type is not null && scalarTypes.Contains(x.Schema.Type))
-                                        .ToArray();
-                //TODO add request body
-
                 functions.Add(new Function
                 {
                     Name = operation.OperationId,
                     Description =
                         operation.Summary.CleanupXMLString() is string summary && !string.IsNullOrEmpty(summary)
                             ? summary
                             : operation.Description.CleanupXMLString(),
-                    Parameters = oasParameters.Length == 0
-                        ? null
-                        : new Parameters
-                        {
-                            Type = "object",
-                            Properties = new Properties(oasParameters.ToDictionary(
-                                static x => x.Name,
-                                static x => new FunctionParameter()
-                                {
-                                    Type = x.Schema.Type ?? string.Empty,
-                                    Description = x.Description.CleanupXMLString(),
-                                    Default = x.Schema.Default?.ToString() ?? string.Empty,
-                                    //TODO enums
-                                })),
-                            Required = oasParameters.Where(static x => x.Required).Select(static x => x.Name).ToList()
-                        },
                     States = GetStatesFromOperation(operation),
                 });
             }
@@ -324,6 +302,4 @@
         }
         return null;
     }
-    private static readonly HashSet<string> scalarTypes = new(StringComparer.OrdinalIgnoreCase) { "string", "number", "integer", "boolean" };
-    //TODO validate this is right, in OAS integer are under type number for the json schema, but integer is ok for query parameters
 }