Updating docs on how to extend the tokens #33229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
khmakoto
approved these changes
Nov 8, 2024
layershifter
reviewed
Nov 8, 2024
| @@ -0,0 +1,407 @@ | |||
| # Migration notes from `@fluentui/[email protected]`to `@fluentui/[email protected]` | |||
There was a problem hiding this comment.
Not sure that we want to this document in a new location. It was good in its time, some info in it is already outdated.
There was a problem hiding this comment.
Yeah agreed. The shorthands info is definitely out of date.
There was a problem hiding this comment.
Removed this doc from the PR.
layershifter
reviewed
Nov 8, 2024
|
|
||
| ⚠ Components which use custom tokens cannot be shared between applications. Keep in mind that any application which uses a component with custom tokens must also add the custom tokens to its own themes. Instead of adding custom tokens inside potentially reusable components, you should talk to design. | ||
| ⚠ Components in this repo should _not_ do this. |
There was a problem hiding this comment.
It's in public docsite, so we probably don't need this
layershifter
reviewed
Nov 8, 2024
Comment on lines
170
to
176
| ``` | ||
|
|
||
| ⚠ Keep in mind that the object generated by the `themeToTokensObject()` will contain all the tokens and will not be tree-shakeable. | ||
| ``` | ||
|
|
||
| ```tsx | ||
| import { themeToTokensObject } from '@fluentui/react-components'; | ||
| ``` | ||
|
|
||
| export const customTokens = themeToTokensObject(customLightTheme); | ||
| ``` |
There was a problem hiding this comment.
Good catch - removed
layershifter
approved these changes
Nov 8, 2024
mainframev
requested changes
Nov 8, 2024
spmonahan
reviewed
Nov 8, 2024
| @@ -0,0 +1,407 @@ | |||
| # Migration notes from `@fluentui/[email protected]`to `@fluentui/[email protected]` | |||
There was a problem hiding this comment.
Yeah agreed. The shorthands info is definitely out of date.
mltejera
force-pushed
the
user/matejera/move-migration-docs
branch
from
ee9eb1f
to
715fe2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave's Shift's existing migration docs in place so as to not break any current links.
Copies the whole document to the current docs folder.
Takes a subset of that out and moves it to