-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scripts-executors): add inferred projects support to start experience #33198
feat(scripts-executors): add inferred projects support to start experience #33198
Conversation
b4a4c11
to
c6324de
Compare
📊 Bundle size report✅ No changes found |
@@ -35,6 +35,9 @@ jobs: | |||
|
|||
- run: yarn nx list @fluentui/workspace-plugin | |||
|
|||
# pre-build react-jsx-runtime - as generate-api executor doesn't provide copy assets capability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be feasible to include this as a dependency for gererate-api
in nx.json, or perhaps even integrate it into an executor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah
my initial thinking when building these executors was to not make generate-api part of build
rather invoke it via nx task dependency definition
"build": "dependsOn": ["^build","generate-api"]
after some thinking I opted out from doing that as build
in our scope ( library domain ) needs integrated both generate-api (.d.ts) and build (js transpilation) - to make things encapsulated while composable right.
Now, this issue is rather exotic in context of react-jsx-runtime project, so while I think it's easy and doable to decouple copy assets into a separate executor/function and add it to both build and generate-api, it creates a bit verbose configuration options that start to be misleading IMO.
Only purpose of generate-api should be run tsc
and rollup types , not completely "sold" in incorporating assets api because this 1 use case we have is a good idea ATM.
Definitely open to more brainstorming here 💪, ty
1b901ad
to
9632eb1
Compare
9632eb1
to
61001e0
Compare
Previous Behavior
New Behavior
local
flag resolution on CIRelated Issue(s)