Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts-executors): add inferred projects support to start experience #33198

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Nov 4, 2024

Previous Behavior

New Behavior

  • feat: adds support to inferred projects
    • metadata retrieval for description
    • target configurations unwrap into separate commands
  • fix: generate-api local flag resolution on CI

Related Issue(s)

@Hotell Hotell changed the title Nx/start/update nx console logic for project crystal feat(scripts-executors): add inferred projects support to start experience Nov 4, 2024
@Hotell Hotell added the NX: core label Nov 4, 2024
@Hotell Hotell force-pushed the nx/start/update-nx-console-logic-for-project-crystal branch from b4a4c11 to c6324de Compare November 4, 2024 14:06
@fabricteam
Copy link
Collaborator

fabricteam commented Nov 4, 2024

📊 Bundle size report

✅ No changes found

@@ -35,6 +35,9 @@ jobs:

- run: yarn nx list @fluentui/workspace-plugin

# pre-build react-jsx-runtime - as generate-api executor doesn't provide copy assets capability
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@dmytrokirpa dmytrokirpa Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be feasible to include this as a dependency for gererate-api in nx.json, or perhaps even integrate it into an executor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

my initial thinking when building these executors was to not make generate-api part of build rather invoke it via nx task dependency definition

"build": "dependsOn": ["^build","generate-api"]

after some thinking I opted out from doing that as build in our scope ( library domain ) needs integrated both generate-api (.d.ts) and build (js transpilation) - to make things encapsulated while composable right.

Now, this issue is rather exotic in context of react-jsx-runtime project, so while I think it's easy and doable to decouple copy assets into a separate executor/function and add it to both build and generate-api, it creates a bit verbose configuration options that start to be misleading IMO.

Only purpose of generate-api should be run tsc and rollup types , not completely "sold" in incorporating assets api because this 1 use case we have is a good idea ATM.

Definitely open to more brainstorming here 💪, ty

@Hotell Hotell force-pushed the nx/start/update-nx-console-logic-for-project-crystal branch from 1b901ad to 9632eb1 Compare November 4, 2024 14:58
@Hotell Hotell force-pushed the nx/start/update-nx-console-logic-for-project-crystal branch from 9632eb1 to 61001e0 Compare November 4, 2024 15:31
@Hotell Hotell marked this pull request as ready for review November 4, 2024 15:48
@Hotell Hotell requested a review from a team as a code owner November 4, 2024 15:48
@Hotell Hotell enabled auto-merge (squash) November 4, 2024 15:48
@Hotell Hotell merged commit 2a6ab96 into microsoft:master Nov 4, 2024
18 checks passed
@Hotell Hotell deleted the nx/start/update-nx-console-logic-for-project-crystal branch November 4, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants