Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: workspace-plugin - generate-api executor doesn't copy assets, thus failing when react-jsx-runtime is needed #33200

Open
2 tasks done
Hotell opened this issue Nov 4, 2024 · 0 comments

Comments

@Hotell
Copy link
Contributor

Hotell commented Nov 4, 2024

Area

workspace-plugin (package)

Environment

any

Current Behavior

after migrating to nx inferred tasks, when in clean repo state, generate-api will fail if react-jsx-runtime is in package dependency tree.

previous generate-api task: https://github.com/microsoft/fluentui/pull/33074/files#diff-f1b0dfbd1e1eb5637dd8f4dcaab583d0fa0ce241e5dbea1d9337240779be34c6L22

failure pipeline:
https://github.com/microsoft/fluentui/actions/runs/11665859795/job/32479506284#step:9:181

Image

Expected Behavior

generate-api should work in clean repo state

Reproduction

https://github.com/microsoft/fluentui/actions/runs/11665859795/job/32479506284#step:9:181

Steps to reproduce

  1. rm -rf packages/**/{dist,lib,lib-commonjs}
  2. yarn nx run react-text:generate-api

Suggested severity

Medium - Has workaround

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@Hotell Hotell changed the title [Bug]: workspace-plugin - generate-api executor doesn't copy assets, thus failing when react-jsx-runtime is needed [Bug]: workspace-plugin - generate-api executor doesn't copy assets, thus failing when react-jsx-runtime is needed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant