-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.4.1rc1 - switch dependency dbtsqlserver to dbtfabric #191
v1.4.1rc1 - switch dependency dbtsqlserver to dbtfabric #191
Conversation
arthurcht
commented
Feb 7, 2024
- bumped version.py to v1.4.1rc1
- switched dependency from "dbt-sqlserver~=1.4.0" to "dbt-fabric~=1.4.0rc3"
- updated to inherit new parent dbt-fabric, with failing tests and macros fixed
…d in 'CREATE TABLE AS SELECT'..." error - switch dependency
…F EXISTS" - switch dependency
…olumn type to datetime2
… in use...duplicate...not permitted" - switch dependency
…ion" macro in relation.sql updated - switch dependency
…cro that does not specify Distribution option in "CREATE TABLE AS SELECT" - switch dependency
…k to dependency switch discussion in CHANGELOG.md - switch dependency
…o "synapse__create_schema_with_authorization", fixed failing test_schema.py by adding "schema_authorization" variable to dbt_profile
@microsoft-github-policy-service agree company="dataroots" |
…ct, not available in dbt-core v1.4.9, see dbt-labs/dbt-core@v1.4.9...v1.7.6)
@microsoft-github-policy-service agree company="dataroots" |
@arthurcht , @nszoni , the integration tests are failing. Could you please check? |
thanks @prdpsvs ! to fix error at "Install dependencies" (i.e. pip install) step, (optional) explanation: so removed |
@prdpsvs PR integration tests failing because |
@arthurcht , Secrets were up to date. I created a new app and updated secrets to make I am not missing on something obvious. Does this have to do anything with taking fabric as a dependency. The connection manager in Fabric adapter went through a few changes. I suspect those changes are causing this error. |
@prdpsvs Secrets still seem to be null, and my colleagues and I have successful tests locally with dbt-fabric as dependency. but as discussed, let's meet to confirm repo's Secrets are correctly configured (per pic below), |