Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.1rc1 - switch dependency dbtsqlserver to dbtfabric #191

Conversation

arthurcht
Copy link
Contributor

  • bumped version.py to v1.4.1rc1
  • switched dependency from "dbt-sqlserver~=1.4.0" to "dbt-fabric~=1.4.0rc3"
  • updated to inherit new parent dbt-fabric, with failing tests and macros fixed

arthurcht and others added 14 commits February 2, 2024 17:43
…d in 'CREATE TABLE AS SELECT'..." error - switch dependency
… in use...duplicate...not permitted" - switch dependency
…ion" macro in relation.sql updated - switch dependency
…cro that does not specify Distribution option in "CREATE TABLE AS SELECT" - switch dependency
…k to dependency switch discussion in CHANGELOG.md - switch dependency
…o "synapse__create_schema_with_authorization", fixed failing test_schema.py by adding "schema_authorization" variable to dbt_profile
@arthurcht
Copy link
Contributor Author

@microsoft-github-policy-service agree company="dataroots"

@arthurcht
Copy link
Contributor Author

@microsoft-github-policy-service agree company="dataroots"

@arthurcht arthurcht marked this pull request as ready for review February 12, 2024 14:23
@nszoni nszoni mentioned this pull request Feb 13, 2024
@prdpsvs
Copy link
Contributor

prdpsvs commented Feb 13, 2024

@arthurcht , @nszoni , the integration tests are failing. Could you please check?

@arthurcht
Copy link
Contributor Author

thanks @prdpsvs ! to fix error at "Install dependencies" (i.e. pip install) step,
I've removed pyodbc from dev_requirements.txt. Please run integration tests with latest commit.

(optional) explanation:
pyodbc requirement was added, for Mac users to avoid "Symbol not found: _SQLAllocHandle" error.
but pyodbc requirement makes pip install fail on Windows and, in this case, Ubuntu-latest too.

so removed pyodbc requirement, for this PR's integration tests to proceed on Ubuntu-latest,
while documenting alerts for Mac users to resolve this issue. cc @nszoni

@arthurcht
Copy link
Contributor Author

@prdpsvs PR integration tests failing because AZURE_CLIENT_ID missing?
could u please check repo's environment variables and help to fix? i don't have repo admin access to view/edit environment variables

@prdpsvs
Copy link
Contributor

prdpsvs commented Feb 16, 2024

@arthurcht , Secrets were up to date. I created a new app and updated secrets to make I am not missing on something obvious. Does this have to do anything with taking fabric as a dependency. The connection manager in Fabric adapter went through a few changes. I suspect those changes are causing this error.

image

@arthurcht
Copy link
Contributor Author

arthurcht commented Feb 19, 2024

@prdpsvs Secrets still seem to be null,
secrets_null

and my colleagues and I have successful tests locally with dbt-fabric as dependency.

but as discussed, let's meet to confirm repo's Secrets are correctly configured (per pic below),
and investigate if "fabric as dependency" is root cause.
configure_secrets

@arthurcht arthurcht closed this Feb 20, 2024
@arthurcht arthurcht mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants