Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Image Build Fix - Allow for Push to a different container registry while building from GitHub #116

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

alexlianides
Copy link
Collaborator

Add new feature to build_app and build_containerImages called --build-from-github.

This feature, when called, will always build the payload-app image from the ghcr.io container registry entry stored within the user's generated spacefx-config.json. This ensures that the application you are building is calling the Microsoft maintained spacefx-base container image, which serves as the base-layer docker image for all space sdk container images.

This allows users to build new container images with build_app from the Github images, and still push the container image to their desired registry they have push_enabled: true within the containerRegistries stored within spacefx-config.json.

@alexlianides alexlianides requested a review from a team as a code owner October 14, 2024 19:01
@alexlianides alexlianides changed the base branch from main to 0.11.0-nightly October 14, 2024 19:01
@alexlianides alexlianides merged commit 7d74aa4 into 0.11.0-nightly Oct 15, 2024
9 checks passed
@alexlianides alexlianides deleted the al/fix-build branch October 15, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants