Container Image Build Fix - Allow for Push to a different container registry while building from GitHub #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new feature to
build_app
andbuild_containerImages
called--build-from-github
.This feature, when called, will always build the payload-app image from the
ghcr.io
container registry entry stored within the user's generatedspacefx-config.json
. This ensures that the application you are building is calling the Microsoft maintainedspacefx-base
container image, which serves as the base-layer docker image for all space sdk container images.This allows users to build new container images with
build_app
from the Github images, and still push the container image to their desired registry they havepush_enabled: true
within the containerRegistries stored withinspacefx-config.json
.