Add SmartLink=false for macos target #1760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using default SmartLink (true) causes a rejection of a macos app, on submission to App Store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdbeen updated?Description
The SmartLink properties have been removed in this GitHub pull request. However, it seems to be causing issues with macOS app validation for the App Store.
The previous pull request was not confirmed to have fixed any actual issues; it was based on the assumption that in some cases, the iOS app might not be able to compile due to the SmartLink flag being set to false. The change in the macOS app was made for consistency, so reverting this change should not cause any issues.
Related PRs or issues
AB#103183
#1753