Skip to content

Commit

Permalink
Merge pull request #1791 from microsoft/release/5.0.6
Browse files Browse the repository at this point in the history
Start new 5.0.6 version
  • Loading branch information
DordeDimitrijev authored Oct 11, 2024
2 parents cedf4d2 + b5490a8 commit d1cb57c
Show file tree
Hide file tree
Showing 66 changed files with 230 additions and 129 deletions.
44 changes: 36 additions & 8 deletions .azurepipelines/build-release-packages-1es.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ extends:
dependsOn: []
pool:
name: Azure Pipelines
image: macos-11
image: macos-12
os: macOS
demands:
- msbuild
Expand All @@ -99,9 +99,6 @@ extends:
filePath: ./build.sh
arguments: '"version.cake" -t SetReleaseVersion'

- bash: 'sudo $AGENT_HOMEDIRECTORY/scripts/select-xamarin-sdk.sh 6_12_0'
displayName: 'Use Xamarin Bundle 6.12.0'

- task: JavaToolInstaller@0
displayName: 'Use Java 11'
inputs:
Expand All @@ -116,6 +113,12 @@ extends:
SecretsFilter: 'appcenter-sdk-blob-storage-access-secret'
RunAsPreJob: false

- task: UseDotNet@2
displayName: 'Install .NET SDK'
inputs:
packageType: 'sdk'
version: '8.x'

- bash: 'dotnet workload install android ios macos maccatalyst'
displayName: 'Install .NET workloads'

Expand All @@ -126,6 +129,19 @@ extends:
arguments: '--StorageAuthParams="$(appcenter-sdk-blob-storage-access-secret)"'
Version: 2.2.0

- task: Bash@3
displayName: 'Install Mono, Xamarin and MSBuild'
inputs:
targetType: 'inline'
script: |
brew update
brew install mono
brew install --cask xamarin-mac
brew install --cask xamarin-ios
brew install --cask xamarin-android
echo "Mono version: $(mono --version)"
echo "MSBuild version: $(msbuild -version)"
- task: cake-build.cake.cake-build-task.Cake@2
displayName: 'Prepare Xamarin Assemblies'
inputs:
Expand All @@ -149,6 +165,8 @@ extends:
jobs:
- job: Package
timeoutInMinutes: 180
variables:
VSVERSION: 2022
templateContext:
outputs:
- output: pipelineArtifact
Expand Down Expand Up @@ -205,11 +223,16 @@ extends:
.\scripts\strong-named-sign.cmd "$(Build.ArtifactStagingDirectory)\assemblies" "$(Agent.TempDirectory)\appcenter-pair-key.snk"
displayName: 'Sign assemblies with strong naming'
- task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@2
- task: EsrpCodeSigning@5
displayName: 'Sign Assemblies'
inputs:
ConnectedServiceName: 'MobileCenter-ESRP'
ConnectedServiceName: 'App Center - Code Signing (WIF)'
FolderPath: '$(Build.ArtifactStagingDirectory)\assemblies'
AppRegistrationClientId: '56ecf8eb-6143-4da0-9a53-716e9c2e6e86'
AppRegistrationTenantId: '72f988bf-86f1-41af-91ab-2d7cd011db47'
AuthAKVName: 'code-signing-poduction'
AuthCertName: 'appcenter-codesigning-auth'
AuthSignCertName: 'CodeSigning-Certificate-Managed'
Pattern: '*.dll,*.winmd'
signConfigType: inlineSignParams
inlineOperation: |
Expand Down Expand Up @@ -293,11 +316,16 @@ extends:
arguments: '--MainPackage=true --AssembliesPath="$(Build.ArtifactStagingDirectory)\assemblies" --StorageAuthParams="$(appcenter-sdk-blob-storage-access-secret)"'
Version: 2.2.0

- task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@2
- task: EsrpCodeSigning@5
displayName: 'Sign Packages'
enabled: true
inputs:
ConnectedServiceName: 'MobileCenter-ESRP'
ConnectedServiceName: 'App Center - Code Signing (WIF)'
AppRegistrationClientId: '56ecf8eb-6143-4da0-9a53-716e9c2e6e86'
AppRegistrationTenantId: '72f988bf-86f1-41af-91ab-2d7cd011db47'
AuthAKVName: 'code-signing-poduction'
AuthCertName: 'appcenter-codesigning-auth'
AuthSignCertName: 'CodeSigning-Certificate-Managed'
FolderPath: '$(System.DefaultWorkingDirectory)/'
Pattern: 'Microsoft.AppCenter*.nupkg'
signConfigType: inlineSignParams
Expand Down
2 changes: 1 addition & 1 deletion Apps/Contoso.Android.Puppet/Properties/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.microsoft.appcenter.xamarin.puppet" android:versionCode="117" android:versionName="5.0.5-SNAPSHOT" android:installLocation="auto">
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.microsoft.appcenter.xamarin.puppet" android:versionCode="119" android:versionName="5.0.6-SNAPSHOT" android:installLocation="auto">
<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="30" />
<application android:label="SXPuppet" android:icon="@drawable/Icon" android:theme="@style/PuppetTheme"></application>
</manifest>
4 changes: 2 additions & 2 deletions Apps/Contoso.Android.Puppet/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("0.0.0.0")]
[assembly: AssemblyFileVersion("5.0.5.0")]
[assembly: AssemblyInformationalVersion("5.0.5-SNAPSHOT")]
[assembly: AssemblyFileVersion("5.0.6.0")]
[assembly: AssemblyInformationalVersion("5.0.6-SNAPSHOT")]
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,14 @@
<Reference Include="Mono.Android" />
</ItemGroup>
<ItemGroup Condition=" '$(Configuration)'=='GooglePlay' ">
<PackageReference Include="Microsoft.AppCenter.DistributePlay" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.DistributePlay" Version="5.0.6" />
</ItemGroup>
<ItemGroup Condition=" '$(Configuration)'!='GooglePlay' ">
<PackageReference Include="Microsoft.AppCenter.Distribute" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Distribute" Version="5.0.6" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.6" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.6" />
<PackageReference Include="Xamarin.Forms" Version="5.0.0.2578" />
</ItemGroup>
<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.microsoft.appcenter.xamarin.forms.demo" android:versionName="5.0.5" android:versionCode="100">
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.microsoft.appcenter.xamarin.forms.demo" android:versionName="5.0.6" android:versionCode="101">
<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="30" />
<application android:label="ACFDemo"></application>
</manifest>
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
// and "{Major}.{Minor}.{Build}.*" will update just the revision.

[assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("5.0.5.0")]
[assembly: AssemblyInformationalVersion("5.0.5")]
[assembly: AssemblyFileVersion("5.0.6.0")]
[assembly: AssemblyInformationalVersion("5.0.6")]

// The following attributes are used to specify the signing key for the assembly,
// if desired. See the Mono documentation for more information about signing.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@
<Reference Include="Xamarin.Mac" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Distribute" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.6" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.6" />
<PackageReference Include="Microsoft.AppCenter.Distribute" Version="5.0.6" />
<PackageReference Include="Xamarin.Forms" Version="5.0.0.2578" />
</ItemGroup>
<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions Apps/Contoso.Forms.Demo/Contoso.Forms.Demo.MacOS/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
<key>CFBundleIdentifier</key>
<string>com.microsoft.appcenter.Contoso-Forms-Demo-MacOS</string>
<key>CFBundleShortVersionString</key>
<string>5.0.5</string>
<string>5.0.6</string>
<key>CFBundleVersion</key>
<string>5.0.5</string>
<string>5.0.6</string>
<key>LSMinimumSystemVersion</key>
<string>10.14</string>
<key>CFBundleDevelopmentRegion</key>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@
</ProjectReference>
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Distribute" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.6" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.6" />
<PackageReference Include="Microsoft.AppCenter.Distribute" Version="5.0.6" />
<PackageReference Include="Xamarin.Forms" Version="4.8.0.1821" />
<PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform" Version="6.2.9" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Package xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10" xmlns:mp="http://schemas.microsoft.com/appx/2014/phone/manifest" xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10" IgnorableNamespaces="uap mp">
<Identity Name="10805zumoTestUser.AppCenter-Contoso.Forms.Demo.UWP" Publisher="CN=B2D1C358-6AF8-4416-BF73-129CC1F3C152" Version="5.0.5.0" />
<Identity Name="10805zumoTestUser.AppCenter-Contoso.Forms.Demo.UWP" Publisher="CN=B2D1C358-6AF8-4416-BF73-129CC1F3C152" Version="5.0.6.0" />
<mp:PhoneIdentity PhoneProductId="fbe02dcf-2c7d-4740-9c2b-0df5e15916e5" PhonePublisherId="00000000-0000-0000-0000-000000000000" />
<Properties>
<DisplayName>AppCenter-Contoso.Forms.Demo.UWP</DisplayName>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("0.0.0.0")]
[assembly: AssemblyFileVersion("5.0.5.0")]
[assembly: AssemblyFileVersion("5.0.6.0")]
[assembly: ComVisible(false)]
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@
<Reference Include="Xamarin.iOS" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Distribute" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.6" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.6" />
<PackageReference Include="Microsoft.AppCenter.Distribute" Version="5.0.6" />
<PackageReference Include="Xamarin.Forms" Version="5.0.0.2578" />
</ItemGroup>
<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions Apps/Contoso.Forms.Demo/Contoso.Forms.Demo.iOS/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<key>CFBundleIdentifier</key>
<string>com.microsoft.appcenter.xamarin.forms.ios.demo</string>
<key>CFBundleVersion</key>
<string>5.0.5</string>
<string>5.0.6</string>
<key>LSRequiresIPhoneOS</key>
<true/>
<key>MinimumOSVersion</key>
Expand Down Expand Up @@ -39,7 +39,7 @@
<key>CFBundleName</key>
<string>ACFDemo</string>
<key>CFBundleShortVersionString</key>
<string>5.0.5</string>
<string>5.0.6</string>
<key>CFBundleURLTypes</key>
<array>
<dict>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<TargetFramework>netstandard2.0</TargetFramework>
<Copyright>Microsoft Corp. All rights reserved.</Copyright>
<Company>Microsoft Corporation</Company>
<Version>5.0.5</Version>
<Version>5.0.6</Version>
<AssemblyVersion>0.0.0.0</AssemblyVersion>
<FileVersion>5.0.5.0</FileVersion>
<FileVersion>5.0.6.0</FileVersion>
<Configurations>Debug;Release;GooglePlay</Configurations>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'GooglePlay|AnyCPU' ">
Expand All @@ -20,14 +20,14 @@
<NoStdLib>false</NoStdLib>
</PropertyGroup>
<ItemGroup Condition=" '$(Configuration)'!='GooglePlay' ">
<PackageReference Include="Microsoft.AppCenter.Distribute" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Distribute" Version="5.0.6" />
</ItemGroup>
<ItemGroup Condition=" '$(Configuration)'=='GooglePlay' ">
<PackageReference Include="Microsoft.AppCenter.DistributePlay" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.DistributePlay" Version="5.0.6" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.6" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.6" />
<PackageReference Include="Xamarin.Forms" Version="5.0.0.2578" />
</ItemGroup>
<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="118" android:versionName="5.0.5-SNAPSHOT" package="com.microsoft.appcenter.xamarin.forms.puppet">
<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="120" android:versionName="5.0.6-SNAPSHOT" package="com.microsoft.appcenter.xamarin.forms.puppet">
<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="30" />
<application android:label="ACFPuppet"></application>
</manifest>
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
// and "{Major}.{Minor}.{Build}.*" will update just the revision.

[assembly: AssemblyVersion("0.0.0.0")]
[assembly: AssemblyFileVersion("5.0.5.0")]
[assembly: AssemblyInformationalVersion("5.0.5-SNAPSHOT")]
[assembly: AssemblyFileVersion("5.0.6.0")]
[assembly: AssemblyInformationalVersion("5.0.6-SNAPSHOT")]

// The following attributes are used to specify the signing key for the assembly,
// if desired. See the Mono documentation for more information about signing.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
<key>CFBundleIdentifier</key>
<string>com.microsoft.appcenter.Contoso-Forms-Puppet-MacOS</string>
<key>CFBundleShortVersionString</key>
<string>5.0.5</string>
<string>5.0.6</string>
<key>CFBundleVersion</key>
<string>5.0.5</string>
<string>5.0.6</string>
<key>LSMinimumSystemVersion</key>
<string>10.14</string>
<key>CFBundleDevelopmentRegion</key>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Package xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10" xmlns:mp="http://schemas.microsoft.com/appx/2014/phone/manifest" xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10" IgnorableNamespaces="uap mp">
<Identity Name="10805zumoTestUser.AppCenter-Contoso.Forms.Puppet.U" Publisher="CN=B2D1C358-6AF8-4416-BF73-129CC1F3C152" Version="5.0.5.0" />
<Identity Name="10805zumoTestUser.AppCenter-Contoso.Forms.Puppet.U" Publisher="CN=B2D1C358-6AF8-4416-BF73-129CC1F3C152" Version="5.0.6.0" />
<mp:PhoneIdentity PhoneProductId="55497ed8-b2ac-4485-ba79-e2b65bb720ed" PhonePublisherId="00000000-0000-0000-0000-000000000000" />
<Properties>
<DisplayName>AppCenter-Contoso.Forms.Puppet.UWP</DisplayName>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("0.0.0.0")]
[assembly: AssemblyFileVersion("5.0.5.0")]
[assembly: AssemblyFileVersion("5.0.6.0")]
[assembly: ComVisible(false)]
4 changes: 2 additions & 2 deletions Apps/Contoso.Forms.Puppet/Contoso.Forms.Puppet.iOS/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
<key>CFBundleIdentifier</key>
<string>com.microsoft.appcenter.xamarin.forms.ios.puppet</string>
<key>CFBundleShortVersionString</key>
<string>5.0.5</string>
<string>5.0.6</string>
<key>CFBundleVersion</key>
<string>5.0.5</string>
<string>5.0.6</string>
<key>LSRequiresIPhoneOS</key>
<true/>
<key>MinimumOSVersion</key>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
// and "{Major}.{Minor}.{Build}.*" will update just the revision.

[assembly: AssemblyVersion("0.0.0.0")]
[assembly: AssemblyFileVersion("5.0.5.0")]
[assembly: AssemblyInformationalVersion("5.0.5-SNAPSHOT")]
[assembly: AssemblyFileVersion("5.0.6.0")]
[assembly: AssemblyInformationalVersion("5.0.6-SNAPSHOT")]

// The following attributes are used to specify the signing key for the assembly,
// if desired. See the Mono documentation for more information about signing.
Expand Down
10 changes: 5 additions & 5 deletions Apps/Contoso.MAUI.Demo/Contoso.MAUI.Demo.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<UsingMauiEssentials>true</UsingMauiEssentials>
<SingleProject>true</SingleProject>
<ImplicitUsings>enable</ImplicitUsings>
<Version>5.0.5</Version>
<Version>5.0.6</Version>
<!-- Display name -->
<ApplicationTitle>Contoso.MAUI.Demo</ApplicationTitle>
<!-- App Identifier -->
Expand Down Expand Up @@ -56,13 +56,13 @@
<None Remove="Platforms\iOS\Resources\Images\socket.png" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.6" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.6" />
</ItemGroup>
<ItemGroup Condition=" '$(Configuration)'!='GooglePlay' ">
<PackageReference Include="Microsoft.AppCenter.Distribute" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Distribute" Version="5.0.6" />
</ItemGroup>
<ItemGroup Condition=" '$(Configuration)'=='GooglePlay' ">
<PackageReference Include="Microsoft.AppCenter.DistributePlay" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.DistributePlay" Version="5.0.6" />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities"
IgnorableNamespaces="uap rescap">

<Identity Name="maui-package-name-placeholder" Publisher="CN=Microsoft" Version="5.0.5.0" />
<Identity Name="maui-package-name-placeholder" Publisher="CN=Microsoft" Version="5.0.6.0" />

<Properties>
<DisplayName>$placeholder$</DisplayName>
Expand Down
4 changes: 2 additions & 2 deletions Apps/Contoso.MacOS.Puppet/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>5.0.5</string>
<string>5.0.6</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>5.0.5</string>
<string>5.0.6</string>
<key>LSMinimumSystemVersion</key>
<string>10.15</string>
<key>NSHumanReadableCopyright</key>
Expand Down
4 changes: 2 additions & 2 deletions Apps/Contoso.UWP.Demo/Contoso.UWP.Demo.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@
</Page>
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.5" />
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="5.0.6" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="5.0.6" />
<PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform" Version="6.2.8" />
</ItemGroup>
<ItemGroup>
Expand Down
Loading

0 comments on commit d1cb57c

Please sign in to comment.