Updated README #4920
Open
Updated README #4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0x5bfa Love this! Great to bring consistency across the different WinUI/WASDK repo's. I was looking at this last week myself: https://github.com/niels9001/WindowsAppSDK Since we now have an official WASDK logo, you might want to copy the assets from my PR? |
|
|
ghost1372
reviewed
Nov 28, 2024
niels9001
requested changes
Nov 28, 2024
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
niels9001
requested changes
Nov 28, 2024
Co-authored-by: Niels Laute <[email protected]>
Lamparter
reviewed
Nov 28, 2024
Co-authored-by: Lamparter <[email protected]>
|
So what blocks this pr, I don't see any reason? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check here for the preview https://github.com/0x5bfa/WindowsAppSDK/tree/5bfa/GH-ReadMe