Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CPP and CS winui instancing samples. #235

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dhoehna
Copy link

@dhoehna dhoehna commented Aug 17, 2022

Description

The winui samples were out of date and the instancing samples demonstrated more features than just instancing making the sample confusing to follow.

I made this change because I recently was on the WinUI show and promised samples.

Target Release

1.0

Checklist

My computer can't run ARM64.

  • [ X] Samples build and run using the Visual Studio versions listed in the Windows development docs.
  • [X ] Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
  • [X ] Samples set the minimum supported OS version to Windows 10 version 1809.
  • [ X] Samples build clean with no warnings or errors.
  • [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
  • If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
  • I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

@dhoehna dhoehna requested a review from gabbybilka August 17, 2022 19:58
@dhoehna
Copy link
Author

dhoehna commented Aug 17, 2022

/azp run SamplesCI-Applifecycle

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants