Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Marching Cubes as mesh extractor #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jclarkk
Copy link

@jclarkk jclarkk commented Dec 24, 2024

Use MC by default

@tomgelu
Copy link

tomgelu commented Dec 24, 2024

Do you have image comparison of the results between FlexiCubes and this marching cubes implementation ?

@jclarkk
Copy link
Author

jclarkk commented Dec 24, 2024

@tomgelu
It would be ineffective to compare a mesh extraction method by image, it would be best to run both flexicubes and marching cubes and then compare results in Blender. I've done so myself on 5 different assets and the object structure was identical.

@0lento
Copy link

0lento commented Dec 26, 2024

I've done some raw undecimated mesh comparisons with this and while it's not 100% identical, I can't really judge if either flexicubes or this outputs nicer looking mesh. I'd say it's close enough and actual raw mesh face count is very close on both, in fact was identical on one test when I just used merge vertices import option on blender.

What's noteworthy about this though, is that in my brief testing, it's seems to use less VRAM to decode mesh with this than it does with flexicubes, so I'm merging this on my low-vram fork for now. Thanks for sharing this!

@jclarkk
Copy link
Author

jclarkk commented Dec 26, 2024

@0lento
Glad to hear it reduces VRAM consumption as I haven't tested that myself, the gsplat implementation should also help in that regard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants