-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspaces] Implement PWA recognition, launch. #35913
Open
donlaci
wants to merge
14
commits into
microsoft:main
Choose a base branch
from
donlaci:Workspaces_PWA
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+841
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…controls to the editor
…ocesses. Update LauncherUI, Launcher
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
crutkas
added
the
Needs-Review
This Pull Request awaits the review of a maintainer.
label
Nov 13, 2024
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
With this code addition the Workspaces will be able to handle PWA applications installed in Edge or Chrome.
The snapshot tool will detect the running PWA apps, get their PwaAppId, which will be stored in the workspaces.json file.
The Editor (and later the Launcher UI) will show the corresponding app name and the app icon.
The launcher will launch the Pwa apps.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Tested locally on a scenarios where there were 3 different edge-Pwa-apps, 3 different chrome-Pwa-apps, edge and chrome also and other apss too.