Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTRun] add support for UUIDv7 generation #35757

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

frederik-hoeft
Copy link

@frederik-hoeft frederik-hoeft commented Nov 4, 2024

Summary of the Pull Request

PR Checklist

  • Closes: Run: Support for UUIDv7 generation #33266
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected -> was marked as Help Wanted
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places -> nothing to add
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx (TODO)

Detailed Description of the Pull Request / Additional comments

This PR implements UUIDv7 generation for PowerToys Run as defined in RFC 9562.

Validation Steps Performed

Added unit tests to ensure the version field is correctly set and to assert subsequently generated UUIDs are time-ordered.

This comment has been minimized.

@frederik-hoeft
Copy link
Author

@microsoft-github-policy-service agree

@frederik-hoeft frederik-hoeft changed the title add Run support for UUIDv7 generation [PTRun] add support for UUIDv7 generation Nov 4, 2024
@crutkas
Copy link
Member

crutkas commented Nov 5, 2024

We will be upgrading to .net 9 shortly. I think they implemented the core logic here to create them.

dotnet/runtime#104124

@frederik-hoeft
Copy link
Author

We will be upgrading to .net 9 shortly. I think they implemented the core logic here to create them.

dotnet/runtime#104124

Oh, that's great news. Thanks for the heads-up. In that case I'll leave this PR on draft until I can switch out the core implementation with the one from .NET 9 😄

@crutkas
Copy link
Member

crutkas commented Nov 7, 2024

#35716 Is the PR for this

@crutkas
Copy link
Member

crutkas commented Nov 13, 2024

@frederik-hoeft .net 9 PR is now in to the main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants