This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
Set of new timeseries transforms #475
Open
ganik
wants to merge
44
commits into
master
Choose a base branch
from
tsaml
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
any conflicts with getting the latest packages so long as the * is used in the PackageReference Version attributes. Keeping this enabled will allow other packages which are not part of the the MachineLearning feed to be retrieved (ie. Microsoft.MLFeaturizers).
ganik
commented
Mar 31, 2020
nuget.config
Outdated
@@ -5,5 +5,7 @@ | |||
</config> | |||
<packageSources> | |||
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" /> | |||
<add key="MachineLearning" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/MachineLearning/nuget/v3/index.json" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these entries
ganik
commented
Mar 31, 2020
src/DotNetBridge/DotNetBridge.csproj
Outdated
<PackageReference Include="Microsoft.ML.LightGBM" Version="1.5.0-preview2" /> | ||
<PackageReference Include="Microsoft.ML.OnnxConverter" Version="0.17.0-preview2" /> | ||
<PackageReference Include="Microsoft.ML.OnnxTransformer" Version="1.5.0-preview2" /> | ||
<PackageReference Include="Microsoft.ML" Version="1.5.0-preview3*" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove *
ganik
commented
Mar 31, 2020
src/Platforms/build.csproj
Outdated
<PackageReference Include="Microsoft.ML.CpuMath" Version="1.5.0-preview3*" /> | ||
<PackageReference Include="Microsoft.ML.EntryPoints" Version="0.17.0-preview3*" /> | ||
<PackageReference Include="Microsoft.ML.Mkl.Components" Version="1.5.0-preview3*" /> | ||
<PackageReference Include="Microsoft.ML.ImageAnalytics" Version="1.5.0-preview3*" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove *
ganik
commented
Mar 31, 2020
<Compile Include="nimbusml\internal\core\timeseries\iidchangepointdetector.py" /> | ||
<Compile Include="nimbusml\internal\core\timeseries\iidspikedetector.py" /> | ||
<Compile Include="nimbusml\internal\core\timeseries\lagleadoperator.py" /> | ||
<Compile Include="nimbusml\internal\core\timeseries\shortdrop.py" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better name for ShortDrop
Unit tests & examples TBD |
Get dependency on ort-featurizers
* tests completed * refactor tests * resolve comments * resolve comments * resolve comments
* Add callstack field to BrdigeRuntime exception (#483) * Add exception stack to the error message * Add callstack field Co-authored-by: Gani Nazirov <[email protected]> * Add callstack field to BrdigeRuntime exception (#483) * Add exception stack to the error message * Add callstack field Co-authored-by: Gani Nazirov <[email protected]> * revert "Add callstack field to BrdigeRuntime exception (#483)" This reverts commit 569ea7b. * add in DateTimeSplitter tests for country * add in big tests for more featurizers Co-authored-by: Gani Nazirov <[email protected]> Co-authored-by: Gani Nazirov <[email protected]>
* check in * fix shape * fix shape
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New transforms added:
LagLeadOperator
SimpleRollingWindow
AnalyticalRollingWindow
ShortDrop
ForecastingPivot