Deprecate python 3.8 support. #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 31, 2024
Merged
motus
approved these changes
Jan 3, 2025
motus
added a commit
that referenced
this pull request
Jan 3, 2025
# Pull Request ## Title Deprecates Python 3.9 support --- ## Description Per https://endoflife.date/python, 3.8 is no longer supported. This PR drops Python 3.8 from the CI pipeline and changes a few small places in the code where we have to check for the python version, but otherwise leaves the rest of the pylint and syntax changes for a future PR. To manage that, we also prepare the use of `pyupgrade` as a formatter, though may convert all formatting checks to use `pre-commit` hooks instead in the future in order to reduce some of the `Makefile` complexity. - See Also: #749 --- ## Type of Change - ✨ Dropped feature -⚠️ Breaking change - 🔄 Refactor --- ## Testing This is a small change for now, without rewrites, to keep testing easier. So usual CI should suffice. --- ## Additional Notes (optional) - A variation on #902 - Python 3.9 will be supported for another 10 months. We can also consider to drop support for it early as well and reduce another round of large codebase rewrites. On the other hand, it might be simple to do later with the introduction of pyupgrade anyways. --- --------- Co-authored-by: Sergiy Matusevych <[email protected]>
bpkroth
added a commit
that referenced
this pull request
Jan 3, 2025
# Pull Request ## Title Reworks build to use pre-commit for format and lint checks. --- ## Description As mentioned in #902 and #903, this refactors the build system to use [`pre-commit`](https://pre-commit.com) for the following reasons: - less complicated Makefile rules - pinned linter versions that can be checked with dependabot more explicitly for easier maintenance - See Also: #749 --- ## Type of Change - ✨ New feature - 🔄 Refactor - 📝 Documentation update - 🧪 Tests --- ## Testing Manually locally and usual CI tests. --- ## Additional Notes (optional) This builds off of #903 and is prep work to change the syntax of the codebase using `pyupgrade`. ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Deprecates Python 3.8 support
Description
Per https://endoflife.date/python, 3.8 is no longer supported.
This PR drops Python 3.8 from the CI pipeline and changes a few small places in the code where we have to check for the python version, but otherwise leaves the rest of the pylint and syntax changes for a future PR.
To manage that, we also prepare the use of
pyupgradeas a formatter, though may convert all formatting checks to usepre-commithooks instead in the future in order to reduce some of theMakefilecomplexity.Type of Change
Testing
This is a small change for now, without rewrites, to keep testing easier.
So usual CI should suffice.
Additional Notes (optional)