Add SSH Support #510
Merged
Add SSH Support #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fa8cab9.
…ort-with-context-manager
bpkroth
added a commit
that referenced
this pull request
Oct 25, 2023
Work towards making the setup/teardown work for the SshService managed by a Context instead of global. To do this, we introspect all of the methods registered for a Service mixin (which we also renamed from `self._services` to `self._service_methods`), and pull out their unique Service instance references from the `__self__` attribute in the bound method that was registered, then store them as `self._services`. This is to handle the case where a single method name was overridden multiple times. At this point, we have enough information to invoke a sort of `__enter__` context for each of those Service instances. However, since we use `__enter__` to invoke all of them, we instead need to implement a separate `_enter_context()` method that does the actual work, and can then be overridden by the subclasses. Unfortunately, this technique make tamper with the order the Services were layered on one another, so any logic that required relying on that order for context setup might be problematic. I don't know if that will actually be an issue, so for now, I'm ignoring the issue and just documenting it. This PR does not include explicit new tests for this, though does have to fixup a few mocks in order to make sure that we're registered bound methods and not just functions. #510 will add additional tests after this is merged.
Co-authored-by: Sergiy Matusevych <[email protected]>
Co-authored-by: Sergiy Matusevych <[email protected]>
Co-authored-by: Sergiy Matusevych <[email protected]>
2 tasks
motus
pushed a commit
that referenced
this pull request
Oct 26, 2023
Extracting out from another refactor of SSH support PR #510
bpkroth
added a commit
that referenced
this pull request
Oct 26, 2023
Per comments in #510 - [x] Convert test classes to `MockService` - [x] Add json schema support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SSH support for remote exec and file copy operations via
asyncssylibrary. Closes ssh environment support #379This requires an event loop thread to operate the async calls in the background without blocking the rest of our main thread operations or changing our APIs dramatically. Instead we interact with all operations as futures after that.
Add json schema config support for SSH
Adds test infrastructure for running SSH servers inside containers via
pytest-dockerwhich usesdocker composeto start/stop them as fixtures. This should work in all dev environments (Linux host, WSL host, Windows host), but is quite sensitive to networking setups.