Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client-presence): Rename ExperimentalPresenceManager to PresenceManager + remove all experimental naming from package #23103

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

WillieHabi
Copy link
Contributor

@WillieHabi WillieHabi commented Nov 15, 2024

Description

Now that Presence package has been promoted from experimental to alpha, we should rename ExperimentalPresenceManager to just PresenceManager.

This PR completeley removes all 'experimental' naming from the Presence package.

@github-actions github-actions bot added area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct public api change Changes to a public API base: main PRs targeted against main branch labels Nov 15, 2024
@WillieHabi WillieHabi changed the title fix(client-presence): Rename ExperimentalPresenceManager to PresenceManager refactor(client-presence): Rename ExperimentalPresenceManager to PresenceManager Nov 15, 2024
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

↑ packages.framework.presence.src:
Line Coverage Change: 0.03%    Branch Coverage Change: No change
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 85.18% 85.18% → No change
Line Coverage 69.69% 69.72% ↑ 0.03%

Baseline commit: 8a75fa9
Baseline build: 307491
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 465.5 KB 465.54 KB +35 Bytes
azureClient.js 562.82 KB 562.87 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 262.12 KB 262.14 KB +14 Bytes
fluidFramework.js 427.12 KB 427.13 KB +14 Bytes
loader.js 134.18 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 149.84 KB 149.85 KB +7 Bytes
odspClient.js 528.61 KB 528.66 KB +49 Bytes
odspDriver.js 97.88 KB 97.9 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB +14 Bytes
sharedString.js 165.77 KB 165.78 KB +7 Bytes
sharedTree.js 417.58 KB 417.58 KB +7 Bytes
Total Size 3.37 MB 3.37 MB +245 Bytes

Baseline commit: 8a75fa9

Generated by 🚫 dangerJS against abc5d1f

@WillieHabi WillieHabi changed the title refactor(client-presence): Rename ExperimentalPresenceManager to PresenceManager refactor(client-presence): Rename ExperimentalPresenceManager to PresenceManager + remove all experimental naming from package Nov 15, 2024
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

Stats:
  444350 links
    3418 destination URLs
       2 URLs ignored
       0 warnings
       0 errors


Copy link
Contributor

@jason-ha jason-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExperimentalPresenceManager name should be kept. Same for ExperimentalPresenceDO.
Also, in general changelog should not be edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants