-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(client-presence): Rename ExperimentalPresenceManager to PresenceManager + remove all experimental naming from package #23103
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↑ packages.framework.presence.src:
Line Coverage Change: 0.03% Branch Coverage Change: No change
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 85.18% | 85.18% | → No change |
Line Coverage | 69.69% | 69.72% | ↑ 0.03% |
Baseline commit: 8a75fa9
Baseline build: 307491
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 8a75fa9 |
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ExperimentalPresenceManager
name should be kept. Same for ExperimentalPresenceDO
.
Also, in general changelog should not be edited.
Description
Now that Presence package has been promoted from experimental to alpha, we should rename ExperimentalPresenceManager to just PresenceManager.
This PR completeley removes all 'experimental' naming from the Presence package.