Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add re-entrancy errors for TreeCheckout #23099

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

noencke
Copy link
Contributor

@noencke noencke commented Nov 15, 2024

Description

This prevents the user from doing various actions to a SharedTree view while in the middle of an ongoing tree edit. The current behavior for these scenarios is undefined and currently tends to give unpredictable internal error messages to users.

@noencke noencke requested a review from a team as a code owner November 15, 2024 00:10
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch labels Nov 15, 2024
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

↑ packages.dds.tree.src.shared-tree:
Line Coverage Change: 0.06%    Branch Coverage Change: 0.40%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 90.88% 91.28% ↑ 0.40%
Line Coverage 97.28% 97.34% ↑ 0.06%

Baseline commit: 136a519
Baseline build: 307305
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +2.35 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 465.72 KB 465.75 KB +35 Bytes
azureClient.js 563.04 KB 563.09 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 262.34 KB 262.35 KB +14 Bytes
fluidFramework.js 427.12 KB 428.19 KB +1.07 KB
loader.js 134.18 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 149.84 KB 149.85 KB +7 Bytes
odspClient.js 528.83 KB 528.88 KB +49 Bytes
odspDriver.js 97.88 KB 97.9 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB +14 Bytes
sharedString.js 165.77 KB 165.78 KB +7 Bytes
sharedTree.js 417.58 KB 418.64 KB +1.06 KB
Total Size 3.37 MB 3.37 MB +2.35 KB

Baseline commit: b054eb5

Generated by 🚫 dangerJS against fdacc35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants