-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Publish ObjectNodeSchema #23090
base: main
Are you sure you want to change the base?
Conversation
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↑ packages.dds.tree.src.simple-tree.api:
Line Coverage Change: 0.01% Branch Coverage Change: No change
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 88.76% | 88.76% | → No change |
Line Coverage | 82.35% | 82.36% | ↑ 0.01% |
↑ packages.dds.tree.src.simple-tree:
Line Coverage Change: 0.03% Branch Coverage Change: 0.01%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 94.07% | 94.08% | ↑ 0.01% |
Line Coverage | 97.23% | 97.26% | ↑ 0.03% |
Baseline commit: 9485e13
Baseline build: 306922
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 9485e13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 20 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- packages/dds/tree/api-report/tree.legacy.public.api.md: Evaluated as low risk
- packages/dds/tree/src/simple-tree/api/tree.ts: Evaluated as low risk
- packages/dds/tree/src/simple-tree/objectNode.ts: Evaluated as low risk
- packages/dds/tree/src/index.ts: Evaluated as low risk
- packages/dds/tree/src/simple-tree/index.ts: Evaluated as low risk
- packages/dds/tree/src/simple-tree/api/schemaFactory.ts: Evaluated as low risk
- packages/dds/tree/src/simple-tree/objectNodeTypes.ts: Evaluated as low risk
- packages/dds/tree/src/test/simple-tree/api/schemaFactory.spec.ts: Evaluated as low risk
- packages/framework/fluid-framework/api-report/fluid-framework.alpha.api.md: Evaluated as low risk
- packages/framework/fluid-framework/api-report/fluid-framework.legacy.alpha.api.md: Evaluated as low risk
- packages/framework/fluid-framework/api-report/fluid-framework.beta.api.md: Evaluated as low risk
- packages/dds/tree/api-report/tree.public.api.md: Evaluated as low risk
- packages/framework/fluid-framework/api-report/fluid-framework.legacy.public.api.md: Evaluated as low risk
- packages/framework/fluid-framework/api-report/fluid-framework.public.api.md: Evaluated as low risk
- packages/dds/tree/api-report/tree.alpha.api.md: Evaluated as low risk
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Description
This tweaks how ObjectNodeSchema is used so it can work with objectRecursive, then makes it public.
This provides much better access to field schema, which us very useful when implementing logic like schema dependency inversions (where the set of schema allowed in a field might not be known at compile time) or generic node processing (where which schema a node has isn't know at compile time).
This API has been very useful internally, and as we support more cases where the schema is unknown at compile time, this is starting to be useful externally as well.
Reviewer Guidance
The review process is outlined on this wiki page.