Fix race condition while establishing connection due to multiplexing in ODSP Driver. #23085
+94
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 13, 2024 16:19
… listener before connection initialization for odsp
github-actions
bot
added
area: driver
msfluid-bot
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Code Coverage Summary
↑ packages.drivers.odsp-driver.src:
Line Coverage Change: 0.05% Branch Coverage Change: 0.06%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 86.27% | 86.33% | ↑ 0.06% |
| Line Coverage | 74.12% | 74.17% | ↑ 0.05% |
Baseline commit: 9485e13
Baseline build: 306922
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +590 Bytes
Baseline commit: 3fe3fa5 |
alexvy86
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Left a few comments and questions. And I'll note I'm not very familiar with this space so definitely look for other reviewers like @tyler-cai-microsoft . I'd also like to see successful test pipeline runs from a test/ branch for this change.
packages/drivers/odsp-driver/src/test/socketTests/socketMock.ts
Outdated
Show resolved
Hide resolved
packages/drivers/odsp-driver/src/test/socketTests/socketTests.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Villarreal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
AB#22192
Following up on this PR: #23078 which we reverted due to assert 0x245 due to the original change. The assert was caused due to registering "disconnect" listener before the initialization.
In this change, I removed registering a listener as we already have disconnectCore which is triggered on disconnection. So using that for rejecting the promise.