Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove noUncheckedIndexedAccess for FF repo #23067

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Remove noUncheckedIndexedAccess for FF repo #23067

wants to merge 6 commits into from
+1 −96

Conversation

RishhiB
Copy link
Contributor

@RishhiB RishhiB commented Nov 12, 2024 •
edited by azure-boards bot
Loading

we are going to be using our custom lint rule no-unchecked-record-access in favor for noUncheckedIndexedAccess
AB#11815

@github-actions github-actions bot added area: build Build related issues base: main PRs targeted against main branch labels Nov 12, 2024
@RishhiB RishhiB marked this pull request as draft November 12, 2024 18:35
Copilot
Copilot AI reviewed Nov 12, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • common/build/build-common/tsconfig.base.json: Language not supported

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dds: tree area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc labels Nov 12, 2024
@RishhiB RishhiB changed the title Disable noUncheckedIndexedAccess for FF repo Remove noUncheckedIndexedAccess for FF repo Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: build Build related issues area: dds: propertydds area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RishhiB