-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable noUncheckedIndexedAccess for container-runtime (#21488) #23066
base: main
Are you sure you want to change the base?
Enable noUncheckedIndexedAccess for container-runtime (#21488) #23066
Conversation
Enable noUncheckedIndexedAccess for container-runtime [AB#8216](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/8216)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↑ packages.runtime.container-runtime.src.gc:
Line Coverage Change: 0.01% Branch Coverage Change: No change
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 97.18% | 97.18% | → No change |
Line Coverage | 96.45% | 96.46% | ↑ 0.01% |
↑ packages.runtime.container-runtime.src.summary:
Line Coverage Change: 0.01% Branch Coverage Change: No change
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 95.82% | 95.82% | → No change |
Line Coverage | 84.84% | 84.85% | ↑ 0.01% |
↑ packages.runtime.container-runtime.src:
Line Coverage Change: 0.01% Branch Coverage Change: No change
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 92.90% | 92.90% | → No change |
Line Coverage | 94.53% | 94.54% | ↑ 0.01% |
↑ packages.runtime.container-runtime.src.opLifecycle:
Line Coverage Change: 0.04% Branch Coverage Change: No change
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 95.23% | 95.23% | → No change |
Line Coverage | 95.39% | 95.43% | ↑ 0.04% |
Baseline commit: c7730cc
Baseline build: 306006
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +237 Bytes
Baseline commit: c7730cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 12 out of 12 changed files in this pull request and generated no suggestions.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
This reverts commit db45810.
Since we now have a lint rule that replaces our need for noUncheckedIndexedAccess, removing the code we added when enabling noUncheckedIndexedAccess
AB#11815