Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added initial test for fetchReason #23057

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarioJGMsoft
Copy link
Contributor

Description

Create new test to make sure that the added code is functioning as intended and see what is going to be sent from now to AFR

Reviewer Guidance

Let me know if there's a better way to create the test

@github-actions github-actions bot added area: driver Driver related issues base: main PRs targeted against main branch labels Nov 11, 2024
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

No packages impacted by the change.


Baseline commit: e0e9c89
Baseline build: 305911
Happy Coding!!

Code coverage comparison check passed!!

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 suggestion.

Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more

@@ -142,4 +142,16 @@ describe("DocumentService", () => {
assert.equal(documentService.policies?.summarizeProtocolTree, true);
stubbedDeltaConnectionCreate.restore();
});

it.only("DocumentDeltaStorageService sends fetchReason along with fetchMessages", async () => {
Copy link
Preview

Copilot AI Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 'it.only' will cause only this test to run, potentially skipping other tests. Remove 'only' to ensure all tests are executed.

Suggested change
it.only("DocumentDeltaStorageService sends fetchReason along with fetchMessages", async () => {
it("DocumentDeltaStorageService sends fetchReason along with fetchMessages", async () => {

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants