Enable @typescript-eslint/member-delimiter-style and @typescript-eslint/semi #10172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
github-actions
bot
added
area: dds: propertydds
area: dds: sharedstring
area: examples
tylerbutler
commented
May 6, 2022
| }, | ||
| "singleline": { | ||
| "delimiter": "semi", | ||
| "requireLast": true |
There was a problem hiding this comment.
The default for single-line is false, which seems inconsistent to me, so I changed it. The tree projects, which currently use prettier, also omit trailing semicolons in single-line cases. What say you all?
There was a problem hiding this comment.
No strong opinion from me, my default is to prefer minimal change to the repo unless/until someone has a strong opinion.
ChumpChief
approved these changes
May 6, 2022
| }, | ||
| "singleline": { | ||
| "delimiter": "semi", | ||
| "requireLast": true |
There was a problem hiding this comment.
No strong opinion from me, my default is to prefer minimal change to the repo unless/until someone has a strong opinion.
sonalivdeshpande
pushed a commit
that referenced
this pull request
May 15, 2022
sonalivdeshpande
pushed a commit
to sonalivdeshpande/FluidFramework
that referenced
this pull request
May 17, 2022
sonalivdeshpande
pushed a commit
to sonalivdeshpande/FluidFramework
that referenced
this pull request
May 17, 2022
anthony-murphy
pushed a commit
that referenced
this pull request
May 18, 2022
sonalivdeshpande
pushed a commit
to sonalivdeshpande/FluidFramework
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables and pre-emptively applies fixes for ESLint
@typescript-eslint/member-delimiter-styleand@typescript-eslint/semirules that will be part of the default lint config (see #9748). This PR represents no functional changes.