-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filtered streaming fix #604
base: jegao/LabelHotFix
Are you sure you want to change the base?
Conversation
So the main logical change in this PR, is that we get rid of frozen point concept, but medoids (global or for any label) can never be deleted? Meaning that we need to skip outputting them at search time, if they are deleted.. |
So now location_to_tag and tag_to_location will not contain these medoids once they are deleted.. Are we making sure that some other new inserted node doesnt take up these locations and get inserted there? In other words, we now lose the invariant delete_set.size() + location_to_tag.size() + empty_slots = _max_points? |
the medoids are not moving to delete set, so it won't be assigned to other nodes again in insert operation. For the question "Meaning that we need to skip outputting them at search time, if they are deleted", yes, they may skip outputting if they got deleted, the logic is as the same as using frozen points: In previous logic we start with frozen points, while the frozen points are selected in searching, we also need to skip them, there are no different here. For the question "lose the invariant delete_set.size() + location_to_tag.size() + empty_slots = _max_points", yes. |
Reference Issues/PRs
What does this implement/fix? Briefly explain your changes.
Any other comments?