Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dkbennett nativepluginsample #39

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dkbennett
Copy link
Member

Adds native plugins sample to the Desktop Bridge samples.

dkbennett and others added 6 commits May 24, 2017 12:17
Adds three projects that add an extension host to a WPF app and builds two apps that deliver native dlls for use in that app.
@vladimp
Copy link
Contributor

vladimp commented May 24, 2017

Thanks for putting it together!

  1. Please format the readme file similar to the other samples, I mean header, a short intro about what it demonstrates then the part that you have about the sample parts and the last how to utilze it.
  2. Consider to change the names from DLLExtension and DLLExtension2 to something like DLLExtensionNative and DLLExtensionManaged..
  3. I failed to build the ExtensionHost packaging project getting tons of errors, I saw this kind of errors with the combination of the NuGet package and the ref to project that you are using, however I don’t see the Nuget in your solution… Can you try the other packaging approach that we publically document here. (with the sepreate win32 folder)
  4. Please make sure the min/max versions in the manifest; 14393 and 15063..

Kudos on the comments in the code!

Thanks,
Vlad

@microsoft microsoft deleted a comment from msftclas Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants