Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'CsWinRTEnableManifestFreeActivation' feature switch #1887

Open
wants to merge 7 commits into
base: staging/2.3
Choose a base branch
from

Conversation

Sergio0694
Copy link
Member

This PR adds the new "CsWinRTEnableManifestFreeActivation" feature switch (enabled by default), which allows disabling the manifest-free fallback path for WinRT activation. When disabled, all fallback code will be removed, and trying to activate a type that is not registered will throw NotSupportedException. This can be useful to:

  • Trim more code when manifest free is not needed
  • Make it easy to identify ACIDs that are unintentionally missing from the APPX manifest

Ideally, packaged apps should strive to be able to run with this feature switch disabled, for best performance.

@Sergio0694 Sergio0694 added performance Related to performance work trimming labels Dec 13, 2024
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/manifest-free-switch branch 3 times, most recently from 9fa2dc2 to 0c1656c Compare December 14, 2024 01:56
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/manifest-free-switch branch from 0c1656c to b25b072 Compare December 14, 2024 08:01
@Sergio0694
Copy link
Member Author

Can confirm this trims everything as expected:

image

Exceptions also work as expected:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Related to performance work trimming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant