Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash for Device not found #51

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Fix crash for Device not found #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8adffa8
Fix crash for Device not found
stan-sz Oct 14, 2024
5d3f65f
Update Directory.Build.props
stan-sz Oct 14, 2024
b75f301
Update README.md
stan-sz Oct 14, 2024
4bb1b64
Update VolumeInfoCache.cs
stan-sz Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<PropertyGroup>

<!-- DOCSYNC: When changing version number update README.md -->
<Version>0.3.11.0</Version>
<Version>0.3.12.0</Version>
<AssemblyVersion>0.9.9999.0</AssemblyVersion>

<Company>Microsoft</Company>
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ File clones on Windows do not actually allocate space on-drive for the clone. Th

[![NuGet version (CopyOnWrite)](https://img.shields.io/nuget/v/CopyOnWrite?style=plastic)](https://www.nuget.org/packages/CopyOnWrite)

* 0.3.12 October 2024: Add ERROR_DEV_NOT_EXIST handling on getting free disk space
* 0.3.11 September 2024: Add ERROR_DEV_NOT_EXIST handling on volume enumeration
* 0.3.10 September 2024: Add ERROR_NO_SUCH_DEVICE handling on volume enumeration
* 0.3.9 September 2024: Fix https://github.com/microsoft/CopyOnWrite/issues/44 - follow up on ignoring FILE_NOT_FOUND on volume enumeration
Expand Down
7 changes: 6 additions & 1 deletion lib/Windows/VolumeInfoCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,11 @@ public VolumeInfo GetVolumeForPath(string path)
if (!result)
{
int lastErr = Marshal.GetLastWin32Error();
if (lastErr == NativeMethods.ERROR_DEV_NOT_EXIST)
{
return null;
}

NativeMethods.ThrowSpecificIoException(lastErr,
$"Failed retrieving drive volume cluster layout information for {volumePaths.PrimaryDriveRootPath} with winerror {lastErr}");
}
Expand All @@ -173,4 +178,4 @@ private static int IndexFromDriveLetter(char driveLetter)

return index;
}
}
}
Loading