-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shopify] Sales Channels publishing for new products #27540
Open
tinestaric
wants to merge
22
commits into
microsoft:main
Choose a base branch
from
GediminasGaubys:dev/pmi/SalesChannels
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbuyuka
reviewed
Oct 26, 2024
Apps/W1/Shopify/app/src/GraphQL/Codeunits/ShpfyGQLSalesChannels.Codeunit.al
Outdated
Show resolved
Hide resolved
onbuyuka
reviewed
Oct 26, 2024
onbuyuka
reviewed
Oct 26, 2024
Apps/W1/Shopify/app/src/Products/Codeunits/ShpfyProductAPI.Codeunit.al
Outdated
Show resolved
Hide resolved
onbuyuka
reviewed
Oct 26, 2024
AndreiPanko
reviewed
Oct 31, 2024
Apps/W1/Shopify/app/src/Products/Tables/ShpfySalesChannel.Table.al
Outdated
Show resolved
Hide resolved
onbuyuka
reviewed
Nov 5, 2024
Apps/W1/Shopify/app/src/GraphQL/Codeunits/ShpfyGQLSalesChannels.Codeunit.al
Outdated
Show resolved
Hide resolved
onbuyuka
reviewed
Nov 5, 2024
Apps/W1/Shopify/app/src/GraphQL/Codeunits/ShpfyGQLSalesChannels.Codeunit.al
Outdated
Show resolved
Hide resolved
onbuyuka
reviewed
Nov 5, 2024
onbuyuka
reviewed
Nov 5, 2024
Apps/W1/Shopify/app/src/Products/Tables/ShpfySalesChannel.Table.al
Outdated
Show resolved
Hide resolved
onbuyuka
reviewed
Nov 5, 2024
Apps/W1/Shopify/app/src/Products/Tables/ShpfySalesChannel.Table.al
Outdated
Show resolved
Hide resolved
onbuyuka
reviewed
Nov 5, 2024
Apps/W1/Shopify/test/Products/ShpfySalesChannelHelper.Codeunit.al
Outdated
Show resolved
Hide resolved
onbuyuka
reviewed
Nov 5, 2024
Apps/W1/Shopify/test/Products/ShpfySalesChannelSubs.Codeunit.al
Outdated
Show resolved
Hide resolved
onbuyuka
reviewed
Nov 5, 2024
Apps/W1/Shopify/test/Products/ShpfySalesChannelSubs.Codeunit.al
Outdated
Show resolved
Hide resolved
@petemchlk left some comments, otherwise looks good |
…aubys/ALAppExtensions into dev/pmi/SalesChannels
@onbuyuka applied your suggestions :) |
onbuyuka
approved these changes
Nov 6, 2024
Issue #26819 is not valid. Please make sure you link an issue that exists, is open and is approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does not have a related issue as it's part of delivery for development agreed directly with @AndreiPanko
Fixes #26819
Sales Channels publishing for new products
This PR contains new functionality where user can choose Sales Channels which will new products be published to on creation from BC.
Solution contains new page and table - Shopify Sales Channels available from Shopify Shop. On page user can import sales channels available for shop and choose to which new products should be published to. If user does not choose any of the channels, then channel "Online Shop" is being used by default.
In case user did not import Sales Channels before running create product sales channels are pulled from Shopify on before publishing and default channel is used.
Pulled sales channels are updated in BC - in case the channel was removed in Shopify its removed from list in BC.
Modified/new objects
Fixes AB#556526, AB#550319