Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intrastat Core] Changes to "Validate Codeunit ID" and "Content Codeunit ID" behavior on "Intrastat Report" page #27350

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

matjaz-sega
Copy link
Contributor

@matjaz-sega matjaz-sega commented Sep 30, 2024

Summary

There is a problem with current implementation of "Validate Codeunit ID" and "Content Codeunit ID" in several actions on "Intrastat Report" page. I have rewritten the code so that Validate and Content codeunits can be used independently of each other. Whenever validation is performed, if "Validate Codeunit ID" is not set in "VAT Reports Configuration", standard validation code is executed. Whenever file creation is performed, if "Content Codeunit ID" is not set in "VAT Reports Configuration", standard export code is executed.

Work Item(s)

fixes #27114

Fixes AB#554367

@matjaz-sega matjaz-sega requested a review from a team as a code owner September 30, 2024 12:31
@matjaz-sega
Copy link
Contributor Author

@microsoft-github-policy-service agree company="BE-terna"

Copy link

@RadoArvay RadoArvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! As we discussed.

@JesperSchulz JesperSchulz self-assigned this Oct 9, 2024
@JesperSchulz JesperSchulz added Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item labels Oct 9, 2024
@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Oct 25, 2024
@JesperSchulz
Copy link
Contributor

The PR was merged internally. In order to merge here on GitHub, we need a succeeding build. Not sure why it failed... will re-run.

@JesperSchulz JesperSchulz enabled auto-merge (squash) October 26, 2024 06:11
@mazhelez mazhelez merged commit cb1d70e into microsoft:main Oct 28, 2024
9 of 12 checks passed
@JesperSchulz
Copy link
Contributor

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 25897.

@JesperSchulz JesperSchulz added the ships-in-future-update Fix ships in a future update label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed ships-in-future-update Fix ships in a future update
Projects
None yet
4 participants