Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Wildcards and Filter on Test Codeunit Name #16096

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

ChrisBlankDe
Copy link
Contributor

@ChrisBlankDe ChrisBlankDe commented Jan 28, 2022

Now Filtering on CodeunitName is possible like its possible on TestMethodName.

Now Filterung on CodeunitName is possible like its possible on TestMethodName.
@JesperSchulz
Copy link
Contributor

@ChrisBlankDe / @nikolakukrika, this PR has been sitting idle for a year now. How far are we from getting the code approved in a review? I think we should either get this processed asap, or closed. What do you think? Can we land this one?

@ChrisBlankDe
Copy link
Contributor Author

@ChrisBlankDe / @nikolakukrika, this PR has been sitting idle for a year now. How far are we from getting the code approved in a review? I think we should either get this processed asap, or closed. What do you think? Can we land this one?

i had hoped to improve the test runner for us and other partners.
I can understand the design issues of @nikolakukrika. however, I strictly follow the example of Microsoft a few lines below.
the problems listed appear in the same way in msft's solution.
fixing microsoft's code at this point would be a breaking change and would have to be synchronized with the bccontainerhelper.

by the way, the casing corresponds to the microsoft standard at the time of the PR. funny that after one year suddenly someone cares. and obviously more people are bothered than the weaknesses in the process :)

I can correct the casing if there is a chance that the pull request will be adopted.

@JesperSchulz
Copy link
Contributor

@nikolakukrika, could you help driving this PR to a conclusion?

Copy link
Contributor

@JesperSchulz JesperSchulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this!

@JesperSchulz JesperSchulz merged commit 3376771 into microsoft:main Aug 16, 2023
10 of 12 checks passed
@JesperSchulz
Copy link
Contributor

Shipping with 23.0 🥳

@JesperSchulz JesperSchulz added processing-PR The PR is currently being reviewed ships-in-future-update Fix ships in a future update labels Aug 16, 2023
@JesperSchulz
Copy link
Contributor

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 11839.

aholstrup1 pushed a commit to aholstrup1/ALAppExtensions that referenced this pull request Sep 6, 2024
Now Filtering on CodeunitName is possible like its possible on
TestMethodName.

---------

Co-authored-by: Blank, Christoph <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processing-PR The PR is currently being reviewed ships-in-future-update Fix ships in a future update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants